Skip to content

implement grpc comms#537

Open
marcello33 wants to merge 1 commit intohv2/eip1559-and-rio-at-128from
mardizzone/grpc_impl
Open

implement grpc comms#537
marcello33 wants to merge 1 commit intohv2/eip1559-and-rio-at-128from
mardizzone/grpc_impl

Conversation

@marcello33
Copy link
Copy Markdown
Collaborator

@marcello33 marcello33 requested review from a team and leovct April 24, 2026 08:17
@leovct
Copy link
Copy Markdown
Member

leovct commented Apr 24, 2026

lgtm but heimdall is not able to start in CI?

2026/04/24 07:50:49 unable to unmarshall config Error decoding failed due to the following error(s):
'custom' has invalid keys: main_chain_gas_fee_cap, main_chain_gas_tip_cap

@marcello33
Copy link
Copy Markdown
Collaborator Author

lgtm but heimdall is not able to start in CI?

2026/04/24 07:50:49 unable to unmarshall config Error decoding failed due to the following error(s):

'custom' has invalid keys: main_chain_gas_fee_cap, main_chain_gas_tip_cap

Yeah @leovct
It's because we use the latest released version here which doesn't have those flags, whilst develop does. It should be super safe to merge (I tested this locally many times)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants