Skip to content

prefetcher: builder-phase prefetch + streaming worker pool #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucca30 wants to merge 12 commits into
base: develop
Choose a base branch
from

prefetcher: signal interrupt on prepareWork early-return

22e8292
Select commit
Loading
Failed to load commit list.
Open

prefetcher: builder-phase prefetch + streaming worker pool #2192

prefetcher: signal interrupt on prepareWork early-return
22e8292
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 22, 2026 in 31m 43s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit miner/worker.go:2593-2596 collectPlanBatch missing sentThisPhase filter — symmetric dup of prior plan→scanOverflow fix

Annotations

Check warning on line 2596 in miner/worker.go

See this annotation in the file changed.

@claude claude / Claude Code Review

collectPlanBatch missing sentThisPhase filter — symmetric dup of prior plan→scanOverflow fix 

In `runBuilderTxProvider`, the `sentThisPhase` dedup guard is one-directional: `scanOverflow` consults it (miner/worker.go:1932), but `collectPlanBatch` (miner/worker.go:2593-2596) is not passed `sentThisPhase` and only filters against `prefetchedHashes`. A tx T emitted by `scanOverflow` in iteration N (recorded in `sentThisPhase`, `h.Shift()`-ed out of `overflowHeap`, worker mid-EVM) can be re-read from `planCh`'s buffer by `collectPlanBatch` in iteration N+1 and forwarded a second time — a sec
View more details on Claude