Skip to content

internal/cli: enabled witness filestore by default#2191

Merged
pratikspatil024 merged 1 commit intodevelopfrom
psp-enable-wit-fs
Apr 24, 2026
Merged

internal/cli: enabled witness filestore by default#2191
pratikspatil024 merged 1 commit intodevelopfrom
psp-enable-wit-fs

Conversation

@pratikspatil024
Copy link
Copy Markdown
Member

Enabled the filesysyem based witness storage, implemented in #2098, by default.

Copilot AI review requested due to automatic review settings April 20, 2026 10:32
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CLI’s default node configuration to enable the filesystem-backed witness store by default, aligning the CLI defaults with the witness filestore implementation introduced in the referenced PR.

Changes:

  • Set Witness.FileStore to true in DefaultConfig() so new nodes default to filesystem witness storage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@claude
Copy link
Copy Markdown

claude Bot commented Apr 20, 2026

Code Review

1 issue found:

docs/cli/default_config.toml not regenerated

The default config docs are now out of sync. docs/cli/default_config.toml still has filestore = false (line 240), but this change sets the default to true in config.go line 1050.

Per CLAUDE.md, make docs should be run to regenerate CLI docs and default config.

Please run make docs and include the updated docs/cli/default_config.toml in this PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.96%. Comparing base (3193054) to head (3a100c2).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2191      +/-   ##
===========================================
+ Coverage    51.93%   51.96%   +0.03%     
===========================================
  Files          884      884              
  Lines       155494   155494              
===========================================
+ Hits         80754    80808      +54     
+ Misses       69522    69481      -41     
+ Partials      5218     5205      -13     
Files with missing lines Coverage Δ
internal/cli/server/config.go 63.84% <100.00%> (ø)

... and 24 files with indirect coverage changes

Files with missing lines Coverage Δ
internal/cli/server/config.go 63.84% <100.00%> (ø)

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

@pratikspatil024 pratikspatil024 merged commit a255bf3 into develop Apr 24, 2026
28 of 33 checks passed
@pratikspatil024 pratikspatil024 deleted the psp-enable-wit-fs branch April 24, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants