internal/cli: enabled witness filestore by default#2191
internal/cli: enabled witness filestore by default#2191pratikspatil024 merged 1 commit intodevelopfrom
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Pull request overview
This PR updates the CLI’s default node configuration to enable the filesystem-backed witness store by default, aligning the CLI defaults with the witness filestore implementation introduced in the referenced PR.
Changes:
- Set
Witness.FileStoretotrueinDefaultConfig()so new nodes default to filesystem witness storage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Review1 issue found: docs/cli/default_config.toml not regenerated The default config docs are now out of sync. Per CLAUDE.md, Please run |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2191 +/- ##
===========================================
+ Coverage 51.93% 51.96% +0.03%
===========================================
Files 884 884
Lines 155494 155494
===========================================
+ Hits 80754 80808 +54
+ Misses 69522 69481 -41
+ Partials 5218 5205 -13
... and 24 files with indirect coverage changes
🚀 New features to boost your workflow:
|
dc52f9f to
3a100c2
Compare
|



Enabled the filesysyem based witness storage, implemented in #2098, by default.