Skip to content

miner, core, consensus/bor, eth, triedb: pipelined state root computation (PoC) #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pratikspatil024 wants to merge 13 commits into
base: delay_src
Choose a base branch
from

core, core/txpool, miner: PR review fixes + pipelined import hardening

d2d6641
Select commit
Loading
Failed to load commit list.
Open

miner, core, consensus/bor, eth, triedb: pipelined state root computation (PoC) #2180

core, core/txpool, miner: PR review fixes + pipelined import hardening
d2d6641
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 23, 2026 in 1m 17s

Quality Gate failed

Failed conditions
5.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check failure on line 6818 in core/blockchain_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1x0w5Oi9Z6KQlE8hGg&open=AZ1x0w5Oi9Z6KQlE8hGg&pullRequest=2180

Check failure on line 1211 in consensus/bor/bor.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Error changing contract code" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLOFMy6llO4qwxL3&open=AZ1JxLOFMy6llO4qwxL3&pullRequest=2180

Check failure on line 816 in core/blockchain.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 33 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1x0w3ii9Z6KQlE8hGa&open=AZ1x0w3ii9Z6KQlE8hGa&pullRequest=2180

Check failure on line 2356 in miner/worker.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ2V1BYb2ziWcsgoKHrB&open=AZ2V1BYb2ziWcsgoKHrB&pullRequest=2180

Check failure on line 611 in tests/bor/helper.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "0.0.0.0:0" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLQwMy6llO4qwxMD&open=AZ1JxLQwMy6llO4qwxMD&pullRequest=2180

Check warning on line 1008 in miner/pipeline.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 10 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLOWMy6llO4qwxL6&open=AZ1JxLOWMy6llO4qwxL6&pullRequest=2180

Check failure on line 2320 in core/blockchain.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Failed to write block into disk" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLKnMy6llO4qwxLz&open=AZ1JxLKnMy6llO4qwxLz&pullRequest=2180

Check failure on line 1198 in consensus/bor/bor.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Error while committing states" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLOFMy6llO4qwxL4&open=AZ1JxLOFMy6llO4qwxL4&pullRequest=2180

Check failure on line 1021 in consensus/bor/bor.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 47 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ2V1BT92ziWcsgoKHq_&open=AZ2V1BT92ziWcsgoKHq_&pullRequest=2180

Check failure on line 148 in core/block_validator.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "%w (remote: %x local: %x)" 4 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1x0w37i9Z6KQlE8hGd&open=AZ1x0w37i9Z6KQlE8hGd&pullRequest=2180

Check failure on line 1189 in consensus/bor/bor.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Error while committing span" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLOFMy6llO4qwxL2&open=AZ1JxLOFMy6llO4qwxL2&pullRequest=2180

Check failure on line 1031 in core/state/statedb.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 38 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1x0wy8i9Z6KQlE8hGZ&open=AZ1x0wy8i9Z6KQlE8hGZ&pullRequest=2180

Check failure on line 601 in tests/bor/helper.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "InitMiner-" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1JxLQwMy6llO4qwxME&open=AZ1JxLQwMy6llO4qwxME&pullRequest=2180

Check warning on line 914 in miner/pipeline.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary variable declaration and use the expression directly in the condition. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ25JWO-eCqF613oAALQ&open=AZ25JWO-eCqF613oAALQ&pullRequest=2180
View more details on SonarQubeCloud