Skip to content

address comments

a1fa6b9
Select commit
Loading
Failed to load commit list.
Open

Deterministic state syncs #2177

address comments
a1fa6b9
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 4, 2026 in 57s

Quality Gate failed

Annotations

Check failure on line 729 in consensus/bor/heimdall/failover_client_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "secondary should have been tried" 4 times.

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1Jt7KqsCLsiQJ00NQT&open=AZ1Jt7KqsCLsiQJ00NQT&pullRequest=2177

Check warning on line 957 in params/config.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment.

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1FPy-RoC2Lq8aFv3Hh&open=AZ1FPy-RoC2Lq8aFv3Hh&pullRequest=2177

Check failure on line 315 in consensus/bor/heimdall/failover_client_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "should not failover on 503" 4 times.

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1X4dwS8MsCUjGKB-Xv&open=AZ1X4dwS8MsCUjGKB-Xv&pullRequest=2177

Check failure on line 248 in consensus/bor/heimdall/failover_client_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "secondary should have been called" 3 times.

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1Jt7KqsCLsiQJ00NQR&open=AZ1Jt7KqsCLsiQJ00NQR&pullRequest=2177

Check failure on line 338 in consensus/bor/heimdall/failover_client_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "should not failover on shutdown" 4 times.

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1Jt7KqsCLsiQJ00NQS&open=AZ1Jt7KqsCLsiQJ00NQS&pullRequest=2177

Check failure on line 30 in consensus/bor/heimdall/state_sync_url_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "to_time should be RFC3339Nano formatted" 3 times.

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1Z3OZRYOdke2T5BbFl&open=AZ1Z3OZRYOdke2T5BbFl&pullRequest=2177

Check failure on line 730 in consensus/bor/heimdall/failover_client_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "tertiary should have been called" 4 times.

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1Jt7KqsCLsiQJ00NQQ&open=AZ1Jt7KqsCLsiQJ00NQQ&pullRequest=2177

Check failure on line 19 in consensus/bor/heimdall/state_sync_url_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "http://bor0" 4 times.

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1FPy2roC2Lq8aFv3HX&open=AZ1FPy2roC2Lq8aFv3HX&pullRequest=2177

Check failure on line 5301 in consensus/bor/bor_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty or complete the implementation.

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1FPy8poC2Lq8aFv3Hb&open=AZ1FPy8poC2Lq8aFv3Hb&pullRequest=2177