Skip to content

address comments

c6f0d55
Select commit
Loading
Failed to load commit list.
Open

Deterministic state syncs #2177

address comments
c6f0d55
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 1, 2026 in 37s

Quality Gate failed

Annotations

Check warning on line 5427 in consensus/bor/bor_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestCommitStates_FailLoudPostFork_EventsAtHeightError" to match the regular expression ^(_|[a-zA-Z0-9]+)$

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1FPy8poC2Lq8aFv3He&open=AZ1FPy8poC2Lq8aFv3He&pullRequest=2177

Check failure on line 5292 in consensus/bor/bor_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty or complete the implementation.

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1FPy8poC2Lq8aFv3Hb&open=AZ1FPy8poC2Lq8aFv3Hb&pullRequest=2177

Check warning on line 5387 in consensus/bor/bor_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestCommitStates_FailLoudPostFork" to match the regular expression ^(_|[a-zA-Z0-9]+)$

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1FPy8poC2Lq8aFv3Hd&open=AZ1FPy8poC2Lq8aFv3Hd&pullRequest=2177

Check warning on line 37 in consensus/bor/heimdall/state_sync_url_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestBlockHeightByTimeURL_Format" to match the regular expression ^(_|[a-zA-Z0-9]+)$

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1FPy2roC2Lq8aFv3HZ&open=AZ1FPy2roC2Lq8aFv3HZ&pullRequest=2177

Check warning on line 957 in params/config.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment.

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1FPy-RoC2Lq8aFv3Hh&open=AZ1FPy-RoC2Lq8aFv3Hh&pullRequest=2177

Check warning on line 12 in consensus/bor/heimdall/state_sync_url_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestStateSyncsAtHeightURL_Format" to match the regular expression ^(_|[a-zA-Z0-9]+)$

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1FPy2roC2Lq8aFv3HY&open=AZ1FPy2roC2Lq8aFv3HY&pullRequest=2177

Check failure on line 19 in consensus/bor/heimdall/state_sync_url_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "http://bor0" 3 times.

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1FPy2roC2Lq8aFv3HX&open=AZ1FPy2roC2Lq8aFv3HX&pullRequest=2177

Check warning on line 5339 in consensus/bor/bor_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestCommitStates_DeterministicForkSwitch" to match the regular expression ^(_|[a-zA-Z0-9]+)$

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1FPy8poC2Lq8aFv3Hc&open=AZ1FPy8poC2Lq8aFv3Hc&pullRequest=2177

Check warning on line 57 in consensus/bor/heimdall/state_sync_url_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestStateSyncURL_ToTimeIsRFC3339" to match the regular expression ^(_|[a-zA-Z0-9]+)$

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ1FPy2roC2Lq8aFv3Ha&open=AZ1FPy2roC2Lq8aFv3Ha&pullRequest=2177