Skip to content

address claude comments

32a87a8
Select commit
Loading
Failed to load commit list.
Open

(feat): disable pending block creation loop via flag #2175

address claude comments
32a87a8
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 3, 2026 in 11m 19s

Code review found 2 potential issues

Found 5 candidates, confirmed 2. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit docs/cli/server.md:339 Documentation inconsistency: return an error vs return nil for pending RPC behavior

Annotations

Check warning on line 339 in docs/cli/server.md

See this annotation in the file changed.

@claude claude / Claude Code Review

Documentation inconsistency: return an error vs return nil for pending RPC behavior

The flag description is inconsistent across the four files introduced or modified by this PR: `docs/cli/server.md` and `internal/cli/server/flags.go` say RPC queries for 'pending' will 'return an error', while `docs/cli/example_config.toml` and the `config.go` comment say they will 'return nil'. In practice both are partially correct: `eth_getBlockByNumber('pending')` returns null (nil) when the pending block is absent, while `eth_getBlockReceipts` returns an explicit error string—so neither des