refactor: simplify MockChainNote to always hold full note details#2829
Closed
AlgofootPrint wants to merge 7 commits into0xMiden:nextfrom
Closed
refactor: simplify MockChainNote to always hold full note details#2829AlgofootPrint wants to merge 7 commits into0xMiden:nextfrom
AlgofootPrint wants to merge 7 commits into0xMiden:nextfrom
Conversation
* fix: must padw before loading SERIAL_NUM * changelog
Co-authored-by: Claude (Opus) <noreply@anthropic.com>
Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>
) Add benchmarks for CLAIM note (L1/L2 bridge-in) and B2AGG note (bridge-out) consumption alongside existing P2ID benchmarks. - Move shared test vector types and lazy-parsed vectors into miden_agglayer::testing module for reuse across tests and benchmarks - Add benchmark setup functions for CLAIM and B2AGG transactions - Add cycle count assertions for CLAIM note processing (max 64k cycles) Co-authored-by: Claude (Opus) <noreply@anthropic.com> Co-authored-by: partylikeits1983 <partylikeits1983@users.noreply.github.com> Co-authored-by: Bobbin Threadbare <43513081+bobbinth@users.noreply.github.com>
…en#2822) * refactor: make all notes be libs, update CodeBuilder::compile_note_script * refactor: compile and store note script libs instead of scripts themselves * chore: fix comment format * chore: increment crate versions to v0.14.5 --------- Co-authored-by: Bobbin Threadbare <bobbinth@protonmail.com>
Replaces the Public/Private enum variants with a single struct containing a Note and NoteInclusionProof. The note's privacy is carried by the Note itself, so the wrapper no longer needs to distinguish variants. Removes the post-genesis upgrade hack in from_genesis_block and simplifies serialization. Closes 0xMiden#2307
Contributor
|
Closing as duplicate of #2764. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2307
Public(Note, NoteInclusionProof)/Private(NoteId, NoteMetadata, NoteInclusionProof)enum with aplain struct holding
note: Noteandinclusion_proof: NoteInclusionProoffrom_genesis_block; private genesis notes are nowinserted directly using inclusion proofs computed from the genesis block
TryFrom<MockChainNote> for InputNotebecomesFrom(no longer fallible) since the full note is always presentnotethenproofdirectlyTest plan
mock_chain_serialization,private_account_state_update, and otherMockChaintests passMockChainNoteoutside ofmiden-testing(confirmed by grep)