Skip to content

fix(link-map): guard head conversion from memory to avoid overflow panic #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jrootcache wants to merge 1 commit into from
+3 −4
Closed

fix(link-map): guard head conversion from memory to avoid overflow panic #2808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions crates/miden-tx/src/host/link_map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,9 @@ impl<'process> LinkMap<'process> {
if head_ptr == ZERO {
None
} else {
Some(
u32::try_from(head_ptr.as_canonical_u64())
.expect("head ptr should be a valid ptr"),
)
// Be tolerant to potential malformed pointers: return None instead of panicking
// if the value cannot fit into a u32.
u32::try_from(head_ptr.as_canonical_u64()).ok()
Comment on lines +98 to +100
Copy link
Copy Markdown
Contributor

@bobbinth bobbinth Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the pointer is malformed, it would mean that there is a serious bug in the transaction kernel and we should definitely either panic or return an error. So, returning None is probably not a good idea.

}
})
}
Expand Down