Open
Conversation
Add a changelog entry for the tx trace snapshot producer and cover the committed snapshots with schema, source, version, row-count, chiplet-sum, and padded-bracket assertions. Also document that the VM consumer hard-matches padded core-side and chiplet brackets while treating per-chiplet shape as advisory profiling metadata, and leave an explicit ACE accessor TODO for the producer.
huitseeker
approved these changes
Apr 23, 2026
Contributor
huitseeker
left a comment
huitseeker
left a comment
There was a problem hiding this comment.
Thank you so much! I just added a commit that adds tests and docs which make the trace snapshots harder to break: they now check the schema, row totals, and padded trace sizes that the VM benchmark relies on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new bin target under
bin/bench-transaction/src/bin/tx-trace-snapshot.rsthat executes representative transaction contexts through the VM, builds a realExecutionTrace, reads per-component trace lengths fromTraceLenSummary, and writes one JSON snapshot per scenario underbin/bench-transaction/snapshots/. These snapshots are the input to miden-vm's newmiden-synthetic-tx-kernelbench.This is a simplified variant of the cross-repo benchmark approach originally prototyped in #2391. Rather than maintaining a fused bench that runs miden-vm code from within this repo, this producer only writes a small JSON descriptor of the workload; the bench itself lives entirely in miden-vm and has no runtime dependency on protocol.