Rename ChainMmr to PartialBlockChain#1305
Merged
PhilippGackstatter merged 23 commits intonextfrom May 5, 2025
Merged
Conversation
bobbinth
approved these changes
May 3, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left my comment inline, but that's relevant to almost all files - basically, I'd spell "blockchain" as a single word (especially since we already spell it like this in comments).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
ChainMmrtoPartialBlockChain. This is a rename-only PR to make it easier to review.Builds on top of #1304 to avoid merge conflicts and to be able to make a PR in the node against this PR with all changes included.
part of #1173