Conversation
Mirko-von-Leipzig
approved these changes
Apr 24, 2025
bobbinth
approved these changes
Apr 26, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I'll merge this which means we'll need to make a small update in miden-node (cc @Mirko-von-Leipzig).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up for the
AccountTree, addressing this comment: #1254 (comment).Also fixes
compute_mutationsnot checking for account ID prefix uniqueness.In miden-node, this breaks test code in
crates/block-producer/src/test_utils/store.rsbut the fix should be relatively easy cc @Mirko-von-Leipzig.