Skip to content

fix(processor): preserve op_idx in host event errors#3042

Open
KitaroMoha563 wants to merge 2 commits into0xMiden:nextfrom
KitaroMoha563:fix-processor-host-event-op-idx
Open

fix(processor): preserve op_idx in host event errors#3042
KitaroMoha563 wants to merge 2 commits into0xMiden:nextfrom
KitaroMoha563:fix-processor-host-event-op-idx

Conversation

@KitaroMoha563
Copy link
Copy Markdown
Contributor

Describe your changes

Partially addresses #1693.

Preserve the emitting operation index when host event handling fails in the fast processor.

This threads op_idx through the host event diagnostic path for both event handler failures and advice mutation failures raised while applying host-returned mutations. It also adds targeted diagnostic tests to verify both branches now highlight the emit.event(...) instruction instead of the first operation in the basic block.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Commits are signed.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.
  • Updated `CHANGELOG.md'

@github-actions
Copy link
Copy Markdown

Automated check (CONTRIBUTING.md)

Findings:

Recommendations:

  • Consider adding a Test plan or clear review steps.

Next steps:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant