fix(processor): preserve op_idx in host event errors#3042
Open
KitaroMoha563 wants to merge 2 commits into0xMiden:nextfrom
Open
fix(processor): preserve op_idx in host event errors#3042KitaroMoha563 wants to merge 2 commits into0xMiden:nextfrom
KitaroMoha563 wants to merge 2 commits into0xMiden:nextfrom
Conversation
|
Automated check (CONTRIBUTING.md) Findings:
Recommendations:
Next steps:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Partially addresses #1693.
Preserve the emitting operation index when host event handling fails in the fast processor.
This threads
op_idxthrough the host event diagnostic path for both event handler failures and advice mutation failures raised while applying host-returned mutations. It also adds targeted diagnostic tests to verify both branches now highlight theemit.event(...)instruction instead of the first operation in the basic block.Checklist before requesting a review
nextaccording to naming convention.