feat: add action to upload pre-compiled artifacts#3029
Draft
lima-limon-inc wants to merge 1 commit into0xMiden:nextfrom
Draft
feat: add action to upload pre-compiled artifacts#3029lima-limon-inc wants to merge 1 commit into0xMiden:nextfrom
lima-limon-inc wants to merge 1 commit into0xMiden:nextfrom
Conversation
bitwalker
requested changes
Apr 21, 2026
Collaborator
There was a problem hiding this comment.
There are actually two artifacts that we want to produce from this workflow, as part of publishing a release:
- The
miden-vmexecutable, which this PR does currently - The
core.masppackage file, produced by the build script of themiden-core-libcrate. We may need a dedicated Makefile task for this though, since there isn't an easy way to locate the build script output directory without capturing the verbose output ofcargo buildin JSON form. We could either modify the build script to output the.maspto bothOUT_DIRandCARGO_TARGET_DIR/core.masp(so that we have a predictable location to obtain it from), or write acargoscript that links againstmiden-core-liband writes the embedded package bytes to disk somewhere. Either way, we'll need that artifact as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes 0xMiden/midenup#179
With this PR, after a release is made, pre-compiled artifacts are automatically added to the corresponding Github release page. This is used on
midenupin order to speed installs up.Attribution note: This added step was taken from the compiler's CI and adapted for the miden-vm.
Follows up on 0xMiden/miden-client#1936