Skip to content

feat: add action to upload pre-compiled artifacts#3029

Draft
lima-limon-inc wants to merge 1 commit into0xMiden:nextfrom
lambdaclass:fabrizioorsi/miden-vm-artifact
Draft

feat: add action to upload pre-compiled artifacts#3029
lima-limon-inc wants to merge 1 commit into0xMiden:nextfrom
lambdaclass:fabrizioorsi/miden-vm-artifact

Conversation

@lima-limon-inc
Copy link
Copy Markdown
Contributor

Describe your changes

Closes 0xMiden/midenup#179

With this PR, after a release is made, pre-compiled artifacts are automatically added to the corresponding Github release page. This is used on midenup in order to speed installs up.

Attribution note: This added step was taken from the compiler's CI and adapted for the miden-vm.

Follows up on 0xMiden/miden-client#1936

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are actually two artifacts that we want to produce from this workflow, as part of publishing a release:

  1. The miden-vm executable, which this PR does currently
  2. The core.masp package file, produced by the build script of the miden-core-lib crate. We may need a dedicated Makefile task for this though, since there isn't an easy way to locate the build script output directory without capturing the verbose output of cargo build in JSON form. We could either modify the build script to output the .masp to both OUT_DIR and CARGO_TARGET_DIR/core.masp (so that we have a predictable location to obtain it from), or write a cargo script that links against miden-core-lib and writes the embedded package bytes to disk somewhere. Either way, we'll need that artifact as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add artifacts for the miden-vm

2 participants