Skip to content

fix(parallel): align stack word max index bound#3014

Open
mk0walsk wants to merge 5 commits into0xMiden:nextfrom
mk0walsk:fix-parallel-stack-word-max-index-bound02
Open

fix(parallel): align stack word max index bound#3014
mk0walsk wants to merge 5 commits into0xMiden:nextfrom
mk0walsk:fix-parallel-stack-word-max-index-bound02

Conversation

@mk0walsk
Copy link
Copy Markdown

@mk0walsk mk0walsk commented Apr 17, 2026

• ## Describe your changes

This PR fixes a boundary-contract mismatch in parallel stack word access.

  • Updated ReplayProcessor::get_word and ReplayProcessor::set_word to allow start_idx == MIN_STACK_DEPTH - WORD_SIZE (i.e. max valid index 12), matching StackInterface and fast-path behavior.
  • Added regression test stack_set_word_allows_max_start_idx to ensure max-index writes/reads remain valid.
  • Related: Apply code quality fixes and tests #2802

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Commits are signed.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.
  • Updated CHANGELOG.md.

@github-actions
Copy link
Copy Markdown

Automated check (CONTRIBUTING.md)

Findings:

Recommendations:

  • Consider adding a Test plan or clear review steps.

Next steps:

  • Link a relevant issue (e.g., "Fixes Implement SHA256 in Miden Assembly #123") and ensure it is assigned to you.
  • See CONTRIBUTING.md for expectations.
  • If this is a false positive, comment: /quality-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant