processor: add exact continuation stack limit regression test#2995
Open
KitaroMoha563 wants to merge 4 commits into0xMiden:nextfrom
Open
processor: add exact continuation stack limit regression test#2995KitaroMoha563 wants to merge 4 commits into0xMiden:nextfrom
KitaroMoha563 wants to merge 4 commits into0xMiden:nextfrom
Conversation
|
Automated check (CONTRIBUTING.md) Findings:
Recommendations:
Next steps:
|
Contributor
Author
|
The cargo-deny error appears to be the existing |
huitseeker
reviewed
Apr 13, 2026
| - Replaced unsound `ptr::read` with safe unbox in panic recovery, removing UB from potential double-drop ([#2934](https://github.com/0xMiden/miden-vm/pull/2934)). | ||
| - Reverted `InvokeKind::ProcRef` back to `InvokeKind::Exec` in `visit_mut_procref` and added an explanatory comment (#2893). | ||
| - Fixed the release dry-run publish cycle between `miden-air` and `miden-ace-codegen`, and preserved leaf-only DAG imports with explicit snapshots ([#2931](https://github.com/0xMiden/miden-vm/pull/2931)). | ||
| - Added regression coverage for the exact `max_num_continuations` continuation-stack boundary. |
Collaborator
There was a problem hiding this comment.
Please link to this PR, as with the other lines.
Contributor
Author
|
@huitseeker Done, thanks very much for your review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Follow-up to #2825.
Add a regression test that proves execution still succeeds when the continuation stack size is exactly equal to
max_num_continuations.Checklist before requesting a review
nextaccording to naming convention.CHANGELOG.md