fix(assembly-syntax): canonicalize PathBuf::try_from(String)#2991
Open
KitaroMoha563 wants to merge 2 commits into0xMiden:nextfrom
Open
fix(assembly-syntax): canonicalize PathBuf::try_from(String)#2991KitaroMoha563 wants to merge 2 commits into0xMiden:nextfrom
KitaroMoha563 wants to merge 2 commits into0xMiden:nextfrom
Conversation
|
This PR contains unsigned commits. All commits must be cryptographically signed (GPG or SSH). Unsigned commits:
For instructions on setting up commit signing and re-signing existing commits, see: |
|
Automated check (CONTRIBUTING.md) Findings:
Recommendations:
Next steps:
|
e747f98 to
0977c61
Compare
bitwalker
requested changes
Apr 10, 2026
| fn try_from(value: String) -> Result<Self, Self::Error> { | ||
| Path::validate(&value)?; | ||
| Ok(PathBuf { inner: value }) | ||
| PathBuf::new(&value) |
Collaborator
There was a problem hiding this comment.
This will always reallocate, we only want to reallocate if we need to
Contributor
Author
There was a problem hiding this comment.
@bitwalker Updated. Please take another look, thanks for your time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
PathBuf::try_from(String)by delegating toPathBuf::new, so it matchesTryFrom<&str>andFromStr.path_buf.rsto ensurePathBuf::try_from("foo::\"bar\"".to_string())is equal toPathBuf::try_from("foo::\"bar\"")and canonicalizes tofoo::bar.Checklist before requesting a review
nextaccording to naming convention.