Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
97 commits
Select commit Hold shift + click to select a range
0c71228
feat(air): all-LogUp bus refactor (squashed)
adr1anh Apr 13, 2026
34aa578
refactor(air): adapt lookup module to 2856 unified Challenges + MainCols
adr1anh Apr 14, 2026
5076ed6
refactor(air): port hash_kernel + chiplet_responses LogUp buses to 28…
adr1anh Apr 14, 2026
2c1eae2
refactor(air): simplify LogUp bus emitters
adr1anh Apr 14, 2026
b871e61
refactor(air): split MidenLookupAir into Main/Chiplet sub-airs + bus …
adr1anh Apr 14, 2026
e94f78a
refactor(air): delete legacy LogUpMessage trait + unused Msg variants
adr1anh Apr 14, 2026
91766ac
style(air): clean up lint + rustfmt warnings in logup_msg
adr1anh Apr 14, 2026
0478814
feat(air): prover LogUp collection phase into flat LookupFractions
adr1anh Apr 14, 2026
9c8b459
feat(air): real-trace driver for LogUp collection phase
adr1anh Apr 14, 2026
64de7a9
feat(air): fused LogUp accumulator + constraint-path cross-check oracle
adr1anh Apr 14, 2026
71c1f36
perf(air): row-major chunk-parallel fused LogUp accumulator
adr1anh Apr 14, 2026
dc9158b
feat(air): stateless MidenLookupAuxBuilder + LogUp prover wiring
adr1anh Apr 14, 2026
93fa6f6
refactor(air,processor): delete legacy multiset bus + aux trace builders
adr1anh Apr 14, 2026
97d576e
chore(processor): drop dead test helpers + unused imports
adr1anh Apr 14, 2026
906c43c
test(processor): restore bitwise chiplet bus test via LogUp harness
adr1anh Apr 15, 2026
5868081
feat(air): wire stack overflow + hasher perm-link LogUp buses
adr1anh Apr 15, 2026
34f3936
feat(air): LogUp boundary check with open-bus corrections
adr1anh Apr 15, 2026
a568cab
chore(air,docs): fix CI feature-combo + MDX docs build
adr1anh Apr 15, 2026
99e62f6
docs: remove all-LogUp PR design notes from the repo
adr1anh Apr 15, 2026
16af1ef
feat(air,core-lib): implement LogUp boundary check in ACE circuit
adr1anh Apr 16, 2026
e91c9b6
refactor(air): address lookup builder review comments
adr1anh Apr 16, 2026
ea3949b
refactor(air): remove EncodedLookupGroup, unify into LookupGroup
adr1anh Apr 16, 2026
4706691
feat(air): add name + degree annotations to lookup builder API
adr1anh Apr 17, 2026
501e704
refactor(air): consolidate LogUp debug surface into lookup::debug
adr1anh Apr 20, 2026
1307d06
refactor(air): make Challenges shape runtime-sized, move constants Mi…
adr1anh Apr 20, 2026
12be381
refactor(air,processor): collapse kernel ROM chiplet to multiplicity-…
adr1anh Apr 17, 2026
d1dd3e2
refactor(air): drop F=Felt bound from lookup constraint/prover adapters
adr1anh Apr 20, 2026
d6f6cb3
refactor(air): split lookup module into generic + Miden-specific halves
adr1anh Apr 20, 2026
fb90230
refactor(air): generalize lookup validation; split into focused files
adr1anh Apr 20, 2026
ac7bd62
air: domain-separate chiplet interactions via BusId enum
adr1anh Apr 20, 2026
7044801
air: replace Deg::NONE with measured LogUp interaction degrees
adr1anh Apr 20, 2026
01d0d41
air: fix rustdoc broken links and doctest in ace.rs
adr1anh Apr 20, 2026
5d4bc81
test(processor): add column-blind subset-based LogUp bus tests
adr1anh Apr 21, 2026
6d6e82d
refactor(air): single-accumulator LogUp with aux_curr fraction columns
adr1anh Apr 21, 2026
9626a41
air: drop redundant bus labels; swap block-hash payload order
adr1anh Apr 21, 2026
03f2ff9
Merge remote-tracking branch 'origin/next' into adr1anh/bus
adr1anh Apr 21, 2026
a7fbaa7
air: add LogUp boundary emissions and structured debug push log
adr1anh Apr 21, 2026
6e6e46d
chore: clippy cleanup across air and processor
adr1anh Apr 21, 2026
12e14fa
refactor(air): split LogUp module surface into generic + Miden halves
adr1anh Apr 21, 2026
02bddc6
chore: clean up stale artifacts post-LogUp bus refactor
adr1anh Apr 21, 2026
aaefb36
air: override log_quotient_degree for ProcessorAir
adr1anh Apr 21, 2026
10198f6
refactor(air): collapse lookup validation into single validate() entr…
adr1anh Apr 21, 2026
6f3402f
test(miden-vm): re-enable recursive verify + poseidon2 assertion
adr1anh Apr 21, 2026
a7dbe57
air: narrow bus OpFlags surface via LookupOpFlags
adr1anh Apr 21, 2026
aa1296d
air: prover-side boolean fast path for LookupOpFlags
adr1anh Apr 21, 2026
c7adc5b
chore(air): tighten kernel ROM docstrings in chiplets constraints
adr1anh Apr 21, 2026
0ae488b
chore(air): drop blanket allow(dead_code, unused_imports) in lookup m…
adr1anh Apr 21, 2026
d34d2a6
refactor(air): hoist kernel ROM TRACE_WIDTH into trace/chiplets/mod.rs
adr1anh Apr 21, 2026
55a5987
chore(processor): remove diagnostic eprintlns from lookup tests
adr1anh Apr 21, 2026
3fb25b6
refactor(air): reduced_aux_values drives eval_boundary via BoundaryBu…
adr1anh Apr 21, 2026
4e59120
refactor(air): drop public_values from LookupBuilder
adr1anh Apr 21, 2026
156a554
style: apply clippy-fix + rustfmt after cherry-pick
adr1anh Apr 21, 2026
043e411
refactor(air): rename validation/builder.rs to encoding.rs
adr1anh Apr 22, 2026
94d68cd
refactor(air): unify debug validation into one walker
adr1anh Apr 22, 2026
1420e78
docs: add changelog entry for PR #2962
adr1anh Apr 22, 2026
c23c71b
chore(core): revert small change to make diff smaller
adr1anh Apr 22, 2026
4148374
fix(air): clean up dead code flagged by cargo-hack --no-default-features
adr1anh Apr 22, 2026
0e7bfc4
fix(air): wire CryptoStream memory requests into LogUp chiplet_reques…
adr1anh Apr 22, 2026
ffe310e
refactor(air): collapse MidenLookupAir/MidenLookupAuxBuilder onto Pro…
adr1anh Apr 22, 2026
aa34a3b
chore: assert padding values are zero
adr1anh Apr 22, 2026
d177a59
Merge remote-tracking branch 'origin/next' into adr1anh/bus
adr1anh Apr 22, 2026
e37f7a2
fix(air): iterate op_bits directly in decode_opcode_u8
adr1anh Apr 22, 2026
24feee2
docs(air): fix stale intra-doc link to build_logup_aux_trace
adr1anh Apr 22, 2026
bbcbae4
test(processor): restore lost coverage in LogUp bus tests
adr1anh Apr 22, 2026
5a68dc7
docs(air): scrub stale multiset / running-product / SHA references
adr1anh Apr 22, 2026
f335413
docs(air): drop obsolete dead-code-suppression note in buses/mod.rs
adr1anh Apr 22, 2026
ca50494
docs(air): refresh stale legacy-enforce / in-flight-refactor prose
adr1anh Apr 22, 2026
e6d0eff
docs(air): consolidate NUM_LOGUP_COMMITTED_FINALS(#3032) TODO
adr1anh Apr 22, 2026
4f204e9
docs(air): rewrite constraints/lookup/mod.rs header
adr1anh Apr 22, 2026
e8edcee
docs(air): rewrite messages.rs module header
adr1anh Apr 22, 2026
b0d1195
docs(air): retire BUS_* SCREAMING_SNAKE labels in comments
adr1anh Apr 22, 2026
83222d6
chore(air): unify max_message_width across sub-AIRs
adr1anh Apr 22, 2026
3ecabcd
chore(air): tighten ChipletActiveFlags visibility to pub(crate)
adr1anh Apr 22, 2026
79cf4ce
chore(air): drop redundant self-rename in main_air.rs imports
adr1anh Apr 22, 2026
12ea925
style(air): prefer direct method calls in ProcessorAir::eval
adr1anh Apr 22, 2026
c8da3b3
refactor(air): hoist clk_plus_one in chiplet_responses emitter
adr1anh Apr 22, 2026
547fb84
refactor(air): loop over Merkle leaf-word response variants
adr1anh Apr 22, 2026
485c855
refactor(air): unify SiblingMsgBitZero/BitOne and collapse bus loop
adr1anh Apr 22, 2026
d620bc7
refactor(air): merge BitwiseMsg and BitwiseResponseMsg
adr1anh Apr 22, 2026
5dc48ca
refactor(air): lift HasherMsg kind into outer struct
adr1anh Apr 22, 2026
986fa55
refactor(air): drop MemoryHeader; pass memory payload by value
adr1anh Apr 22, 2026
454a348
chore(air): derive BusId::COUNT from the last variant
adr1anh Apr 22, 2026
1d375d5
refactor(air): simplify LookupFractions allocator to from_shape
adr1anh Apr 22, 2026
666a7f4
perf(air): avoid throwaway last-row Vec in build_logup_aux_trace
adr1anh Apr 22, 2026
70d296c
air: enforce fraction columns are zero on the padding row
adr1anh Apr 22, 2026
ed99f0d
refactor(processor): drop unused _trace param from push_sibling
adr1anh Apr 22, 2026
cdc7e51
chore(processor): drop stale allow(dead_code) on build_span_with_resp…
adr1anh Apr 22, 2026
444f6c0
test(processor): tighten hout_count guardrails to == N
adr1anh Apr 22, 2026
1f22abf
docs(processor): rewrite chiplets/mod.rs test doc for subset semantics
adr1anh Apr 22, 2026
291db30
refactor(processor): fold lookup.rs plumbing test into oracle cross-c…
adr1anh Apr 22, 2026
90e25d3
style(processor): replace FQP miden_air::trace::MainTrace with top-of…
adr1anh Apr 22, 2026
f5f29c5
refactor(processor): merge tests/hasher.rs into tests/chiplets/hasher.rs
adr1anh Apr 22, 2026
94d249a
style: apply cargo fmt across bus-cleanup commits
adr1anh Apr 22, 2026
f44e3e8
chore: resolve adr1anh review nits on PR #2962
adr1anh Apr 22, 2026
1d12c6e
docs(air): scrub legacy LogUp column nicknames (M1/M_2+5/C1/...)
adr1anh Apr 22, 2026
664fad3
refactor(air): tighten ProcessorAir LookupAir impl + drop reducer err…
adr1anh Apr 22, 2026
99c1b2d
fix(air): address huitseeker review on PR #2962
adr1anh Apr 23, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
- Added chainable `Test` builders for common test setup in `miden-utils-testing` ([#2957](https://github.com/0xMiden/miden-vm/pull/2957)).
- Speed-up AUX range check trace generation by changing divisors to a flat Vec layout ([#2966](https://github.com/0xMiden/miden-vm/pull/2966)).
- Removed AIR constraint tagging instrumentation, applied a uniform constraint description style across components, and optimized constraint evaluation ([#2856](https://github.com/0xMiden/miden-vm/pull/2856)).
- [BREAKING] Unified all auxiliary-trace buses under a single declarative LogUp `LookupAir` shared by the verifier, prover aux-trace generator, and recursive ACE circuit; reduced committed boundary values to one per trace ([#2962](https://github.com/0xMiden/miden-vm/pull/2962)).
- Collapsed the kernel ROM chiplet to one row per digest with a LogUp multiplicity, eliminating duplicate-callsite rows ([#2962](https://github.com/0xMiden/miden-vm/pull/2962)).

## 0.22.1

Expand Down
361 changes: 192 additions & 169 deletions air/src/ace.rs

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions air/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@ pub fn pcs_params() -> PcsParams {
/// Compile-time constant binding the Fiat-Shamir transcript to the Miden VM AIR.
/// Must match the constants in `crates/lib/core/asm/sys/vm/mod.masm`.
pub const RELATION_DIGEST: [Felt; 4] = [
Felt::new_unchecked(3886624411320157031),
Felt::new_unchecked(5903371486919752653),
Felt::new_unchecked(170319297396068280),
Felt::new_unchecked(5221005507035467697),
Felt::new_unchecked(9778406675021743003),
Felt::new_unchecked(1249738292041492479),
Felt::new_unchecked(18129162047168657414),
Felt::new_unchecked(9359130512581117656),
];

/// Observes PCS protocol parameters into the challenger.
Expand Down Expand Up @@ -314,9 +314,9 @@ mod tests {
layout: LayoutKind::Masm,
};
let air = ProcessorAir;
let batch_config = ace::reduced_aux_batch_config();
let boundary_config = ace::logup_boundary_config();
let circuit =
ace::build_batched_ace_circuit::<_, QuadFelt>(&air, config, &batch_config).unwrap();
ace::build_batched_ace_circuit::<_, QuadFelt>(&air, config, &boundary_config).unwrap();
let encoded = circuit.to_ace().unwrap();
let circuit_commitment: [Felt; 4] = encoded.circuit_hash().into();

Expand Down
30 changes: 0 additions & 30 deletions air/src/constraints/bus.rs

This file was deleted.

Loading
Loading