fix(core): preserve asm-op mappings in MastForest::merge#2958
Open
KitaroMoha563 wants to merge 5 commits into0xMiden:nextfrom
Open
fix(core): preserve asm-op mappings in MastForest::merge#2958KitaroMoha563 wants to merge 5 commits into0xMiden:nextfrom
KitaroMoha563 wants to merge 5 commits into0xMiden:nextfrom
Conversation
huitseeker
reviewed
Apr 3, 2026
huitseeker
requested changes
Apr 3, 2026
Collaborator
huitseeker
left a comment
huitseeker
left a comment
There was a problem hiding this comment.
Thanks! The underlying bug is real: MastForest::merge was losing AssemblyOp source mappings during dedup, which breaks debug/source-location fidelity after linking.
However, the new logic still keeps the first mapping for a deduplicated node. That means results still depend on merge order when both duplicates already have asm-op mappings and one is richer than the other. In that case, source info can still be lost.
relates to #2929
huitseeker
reviewed
Apr 7, 2026
huitseeker
requested changes
Apr 8, 2026
huitseeker
approved these changes
Apr 10, 2026
Collaborator
huitseeker
left a comment
huitseeker
left a comment
There was a problem hiding this comment.
Thanks a lot for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve and remap AssemblyOp source mappings during MastForest::merge, preventing debug source locations from being lost after forest deduplication and link-time merge.