trace generation: follow-up refactoring + couple perf improvements#2953
Open
trace generation: follow-up refactoring + couple perf improvements#2953
Conversation
Nashtare
force-pushed
the
robin/trace_gen_followups
branch
from
b242391 to
ed76d67
Compare
huitseeker
approved these changes
Apr 1, 2026
Collaborator
huitseeker
left a comment
huitseeker
left a comment
There was a problem hiding this comment.
There's a couple of nits, otherwise this LGTM. Beware of #2948 for merging, as this PR and that one will interact.
adr1anh
reviewed
Apr 1, 2026
| let shared = Arc::new(row_major); | ||
| let for_transpose = shared.clone(); | ||
| let lock = self.aux_trace_builders.precomputed_main_transpose.clone(); | ||
| rayon::spawn(move || { |
Contributor
Author
There was a problem hiding this comment.
It's to compute the transpose of the main trace as a background job, so it can be reused when building the aux trace without having to wait for it.
Contributor
Author
|
@adr1anh lmk if this looks good for you! |
Contributor
|
Fixes #2847 |
Contributor
|
We might want to slightly revisit this in the context of #2962, since the auxiliary trace will be entirely constructed in row-major order. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Follow-up of #2937, consisting in:
chipletsandcoretracesRowMajorMatrixlast_program_rowPerformance
Output of
averaged over 5 runs, against
nextand this branch:nextbuild_traceto_row_major_matrixbuild_aux_traceFixes #2847