Skip to content
Merged
Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
e3ac7b6
fix: add integration-tests cache key
TomasArrachea Feb 23, 2026
c33a625
feat: improve caching
TomasArrachea Feb 23, 2026
4e00807
test: cmoment out save-if
TomasArrachea Feb 23, 2026
80ed7c4
fix: remove yarn cache
TomasArrachea Feb 23, 2026
7746277
feat: note transport cache
TomasArrachea Feb 23, 2026
182f4fa
fix: node builder binary name
TomasArrachea Feb 23, 2026
5ffbed4
fix: note-transport cache
TomasArrachea Feb 24, 2026
edc6fa9
test CI
TomasArrachea Feb 24, 2026
8b06ba0
add cache key nightly
TomasArrachea Feb 24, 2026
b421779
feat: restore yarn cache
TomasArrachea Feb 24, 2026
d53f601
feat: uncomment save-if
TomasArrachea Feb 24, 2026
1087704
chore: simplify note-transport cache
TomasArrachea Feb 24, 2026
f64aac1
chore: simplify start binary script
TomasArrachea Feb 24, 2026
bfd1577
review: add separate cache for prover binary
TomasArrachea Feb 24, 2026
91c0c25
chore: build node and note-transport once on miss
TomasArrachea Feb 25, 2026
235681c
chore: adjust path
TomasArrachea Feb 25, 2026
37c5aab
chore: rename jobs
TomasArrachea Feb 25, 2026
77afa7c
chore: avoid rebuilding binaries on cache hit
TomasArrachea Feb 25, 2026
8d0d217
chore: install note-transport via git install
TomasArrachea Feb 25, 2026
0b2d975
review: add TODO comment
TomasArrachea Feb 25, 2026
556d455
chore: restore rust cache for wasm tests
TomasArrachea Feb 25, 2026
1bcf57e
test: temporarily write to cache
TomasArrachea Feb 25, 2026
7d83c46
Revert "test: temporarily write to cache"
TomasArrachea Feb 25, 2026
d62e01d
chore: remove rust-wasm, rust-debug, rust-nightly-release cache entries
TomasArrachea Feb 25, 2026
b1df45a
chore: restore rust-wasm
TomasArrachea Feb 25, 2026
cb9c63a
chore: save rust-wasm cache
TomasArrachea Feb 25, 2026
e673a6e
chore: add build-remote-prover job
TomasArrachea Feb 27, 2026
c724d28
chore: add rust cache for prover and node-builder jobs
TomasArrachea Mar 2, 2026
cffd514
chore: format
TomasArrachea Mar 2, 2026
69cc9a1
chore: lint
TomasArrachea Mar 2, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,25 +34,19 @@ jobs:
- name: Add Rust Cache
uses: Swatinem/rust-cache@v2
with:
shared-key: rust-build
shared-key: rust-release
prefix-key: ${{ env.RUST_CACHE_KEY }}
save-if: ${{ github.ref == 'refs/heads/next' }}
- name: make - build
run: make build
build-wasm:
name: Build Client for wasm
name: Build Client for Wasm
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v6
- name: Install Rust toolchain
run: rustup update --no-self-update
- name: Add wasm32-unknown-unknown target
run: rustup target add wasm32-unknown-unknown
- name: Add Rust Cache
uses: Swatinem/rust-cache@v2
with:
shared-key: rust-build-wasm
prefix-key: ${{ env.RUST_CACHE_KEY }}
save-if: ${{ github.ref == 'refs/heads/next' }}
Comment on lines -51 to -56
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a benefit to keeping these but with save-if: false?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, save-if: false means the job still restores from the cache saved by the build job (which runs with save-if: ${{ github.ref == 'refs/heads/next' }}) but avoids redundant saves that waste time and could evict the canonical cache entry.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rust-wasm cache entry gets written by the Build Web Client job, that compiles the wasm client with a different set of Rust flags and features (defined in the rolup config file) as the make build-wasm command. So IIUC that requires a recompilation anyway.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same applies to the other cases, for the cache to make sense the jobs have to compile the Rust code with the same profile.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we look into standardizing those flags so that we can reuse the cache? Probably not doable, but wonder if you looked into it.

- name: make - build-wasm
run: make build-wasm
47 changes: 8 additions & 39 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,18 @@ concurrency:

env:
CARGO_PROFILE_DEV_DEBUG: 0
RUST_CACHE_KEY: rust-cache-2026.02.18

jobs:
unused_deps:
name: check for unused dependencies
name: Check for unused dependencies
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v6
- name: machete
uses: bnjbvr/cargo-machete@main

typos:
name: spellcheck
name: Spellcheck
runs-on: ubuntu-24.04
timeout-minutes: 5
steps:
Expand All @@ -35,7 +34,7 @@ jobs:
- run: make typos-check

toml:
name: toml formatting
name: Toml formatting
runs-on: ubuntu-24.04
timeout-minutes: 5
steps:
Expand All @@ -46,14 +45,14 @@ jobs:
- run: make toml-check

eslint:
name: "Typescript eslint checks"
name: Typescript eslint checks
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v6
- run: make rust-client-ts-lint

react-sdk-lint:
name: "React SDK lint and typecheck"
name: React SDK lint and typecheck
runs-on: ubuntu-24.04
needs: [wasm-bindgen-types]
steps:
Expand Down Expand Up @@ -85,12 +84,6 @@ jobs:
run: |
rustup update --no-self-update
rustup component add clippy
- name: Add Rust Cache
uses: Swatinem/rust-cache@v2
with:
shared-key: rust-build
prefix-key: ${{ env.RUST_CACHE_KEY }}
save-if: ${{ github.ref == 'refs/heads/next' }}
- name: make - clippy
run: make clippy

Expand All @@ -104,37 +97,25 @@ jobs:
rustup update --no-self-update
rustup target add wasm32-unknown-unknown
rustup component add clippy
- name: Add Rust Cache
uses: Swatinem/rust-cache@v2
with:
shared-key: rust-build-wasm
prefix-key: ${{ env.RUST_CACHE_KEY }}
save-if: ${{ github.ref == 'refs/heads/next' }}
- name: make - clippy-wasm
run: make clippy-wasm

format:
name: format check
name: Format check
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v6
- name: Install Rust with rustfmt
run: |
rustup update --no-self-update nightly
rustup +nightly component add rustfmt
- name: Add Rust Cache
uses: Swatinem/rust-cache@v2
with:
shared-key: rust-build
prefix-key: ${{ env.RUST_CACHE_KEY }}
save-if: ${{ github.ref == 'refs/heads/next' }}
- name: Install prettier
run: yarn install
- name: make - format-check
run: make format-check

wasm-bindgen-types:
name: wasm bindgen types
name: Wasm bindgen types
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v6
Expand All @@ -150,12 +131,6 @@ jobs:
run: |
rustup update --no-self-update
rustup target add wasm32-unknown-unknown
- name: Add Rust Cache
uses: Swatinem/rust-cache@v2
with:
shared-key: rust-build-wasm
prefix-key: ${{ env.RUST_CACHE_KEY }}
save-if: ${{ github.ref == 'refs/heads/next' }}
- name: Install dependencies
working-directory: crates/web-client
run: yarn install --frozen-lockfile
Expand All @@ -172,17 +147,11 @@ jobs:
path: ./crates/web-client/dist

rustdocs:
name: build rust documentation
name: Build rust documentation
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v6
- name: Install Rust
run: rustup update --no-self-update
- name: Add Rust Cache
uses: Swatinem/rust-cache@v2
with:
shared-key: rust-build
prefix-key: ${{ env.RUST_CACHE_KEY }}
save-if: ${{ github.ref == 'refs/heads/next' }}
- name: make - doc
run: make doc
4 changes: 2 additions & 2 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ permissions:
jobs:
# Run tests on the beta channel to provide feedback for Rust team.
beta-test:
name: test on beta channel
name: Test on beta channel
runs-on: ubuntu-24.04
timeout-minutes: 30
steps:
Expand All @@ -32,7 +32,7 @@ jobs:
# Check that our MSRV complies with our specified rust version.
# Each workspace package is verified independently via a matrix for clear per-package errors.
workspace-packages:
name: list packages
name: List packages
runs-on: ubuntu-24.04
outputs:
packages: ${{ steps.package-matrix.outputs.packages }}
Expand Down
Loading