-
Notifications
You must be signed in to change notification settings - Fork 96
chore: improve CI caching #1822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 26 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
e3ac7b6
fix: add integration-tests cache key
TomasArrachea c33a625
feat: improve caching
TomasArrachea 4e00807
test: cmoment out save-if
TomasArrachea 80ed7c4
fix: remove yarn cache
TomasArrachea 7746277
feat: note transport cache
TomasArrachea 182f4fa
fix: node builder binary name
TomasArrachea 5ffbed4
fix: note-transport cache
TomasArrachea edc6fa9
test CI
TomasArrachea 8b06ba0
add cache key nightly
TomasArrachea b421779
feat: restore yarn cache
TomasArrachea d53f601
feat: uncomment save-if
TomasArrachea 1087704
chore: simplify note-transport cache
TomasArrachea f64aac1
chore: simplify start binary script
TomasArrachea bfd1577
review: add separate cache for prover binary
TomasArrachea 91c0c25
chore: build node and note-transport once on miss
TomasArrachea 235681c
chore: adjust path
TomasArrachea 37c5aab
chore: rename jobs
TomasArrachea 77afa7c
chore: avoid rebuilding binaries on cache hit
TomasArrachea 8d0d217
chore: install note-transport via git install
TomasArrachea 0b2d975
review: add TODO comment
TomasArrachea 556d455
chore: restore rust cache for wasm tests
TomasArrachea 1bcf57e
test: temporarily write to cache
TomasArrachea 7d83c46
Revert "test: temporarily write to cache"
TomasArrachea d62e01d
chore: remove rust-wasm, rust-debug, rust-nightly-release cache entries
TomasArrachea b1df45a
chore: restore rust-wasm
TomasArrachea cb9c63a
chore: save rust-wasm cache
TomasArrachea e673a6e
chore: add build-remote-prover job
TomasArrachea c724d28
chore: add rust cache for prover and node-builder jobs
TomasArrachea cffd514
chore: format
TomasArrachea 69cc9a1
chore: lint
TomasArrachea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a benefit to keeping these but with
save-if: false?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
save-if: falsemeans the job still restores from the cache saved by the build job (which runs withsave-if: ${{ github.ref == 'refs/heads/next' }}) but avoids redundant saves that waste time and could evict the canonical cache entry.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rust-wasm cache entry gets written by the Build Web Client job, that compiles the wasm client with a different set of Rust flags and features (defined in the rolup config file) as the
make build-wasmcommand. So IIUC that requires a recompilation anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same applies to the other cases, for the cache to make sense the jobs have to compile the Rust code with the same profile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we look into standardizing those flags so that we can reuse the cache? Probably not doable, but wonder if you looked into it.