Skip to content

chore(lint): fix lint errors+warnings#110

Open
pongstr wants to merge 5 commits intozmkfirmware:mainfrom
pongstr:fix-lint
Open

chore(lint): fix lint errors+warnings#110
pongstr wants to merge 5 commits intozmkfirmware:mainfrom
pongstr:fix-lint

Conversation

@pongstr
Copy link
Copy Markdown
Contributor

@pongstr pongstr commented Dec 12, 2024

  • fixed: fixable lint errors + warnings that doesn't have unintended bad side effects
  • fixed: suppressed ones that break the app (mostly react-hooks/exhaustive-deps)
  • added: eslint-plugin-tailwindcss
    • no-contradicting-classname e.g. avoid p-2 p-3, different Tailwind CSS classnames (pt-2 & pt-3) but targeting the same property several times for the same variant.
    • classnames-order: order classnames for consistency and it makes merge conflict a bit easier to resolve
  • refactor: ConnectModal to adhere to react "rules of hook"
Screenshot 2024-12-13 at 00 26 34

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants