Conversation
bartmkraus
requested review from
MartaSien,
arkjedrz,
miniMax18,
szmktk and
tgbdc7
| - run: | ||
| name: Copy base docker-compose | ||
| command: | | ||
| cp ../docker-compose.base.yml ./docker-compose.base.yml |
There was a problem hiding this comment.
This won't ever work. CI is not working in scope of full_stack repo.
There was a problem hiding this comment.
Yes, this caught me off guard and I haven't come up with a solution yet. But as you mentioned in another comment, having the docker-compose.yml only in the full stack repo would make it very difficult to implement proper CI and testing. It would require some bash scripts which will add extra overhead in terms of their maintenance.
| - db | ||
| db: | ||
| extends: | ||
| file: ../docker-compose.base.yml |
There was a problem hiding this comment.
This would be okay approach with monorepo, but not really with current wonky git submodules approach.
Maybe it'd be better to have whole docker-compose.yml in full stack repo, but then again - CI and testing would become more complex.
2 participants
Related to:
Issue: Improve Docker Compose handling #26
Pull request: Improve Docker Compose handling #28