Skip to content

chore: bump knockout from 3.5.1 to 3.5.3#20884

Closed
dependabot[bot] wants to merge 1 commit intodevfrom
dependabot/npm_and_yarn/knockout-3.5.3
Closed

chore: bump knockout from 3.5.1 to 3.5.3#20884
dependabot[bot] wants to merge 1 commit intodevfrom
dependabot/npm_and_yarn/knockout-3.5.3

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Mar 29, 2026 •
edited
Loading

Bumps knockout from 3.5.1 to 3.5.3.

Release notes

Sourced from knockout's releases.

Version 3.5.3

Fixes a couple of bugs introduced in 3.5.2

  • Bindings fail when Knockout is run in strict mode: #2624
  • Computed type definition missing properties #2623

Version 3.5.2

This release fixes several bugs and adds Trusted Types support:

Fixed bugs:

  • foreach doubles last entries under certain circumstances #2594, #2514
  • Error calling bindingEvent.subscribe before applyBindings #2584
  • Unmatched closing virtual element throws error in production #2582
  • Template binding regression: empty string value throws error #2534
  • IE11: activeElement in IFrame fails rendering #2531
  • Select change event fires before value is updated in 3.5.1 #2530
  • beforeRemove callback index is always 0 #2560
  • Exception when binding propertychange event in non-IE browser #2548
  • Use of reserved word breaking IE <= 8 compatibility #2503
  • ko.cleanNode doesn't remove addEventListener handlers #2314
  • checked binding crashes with null/undefined array #2309
  • foreach descendant bindings evaluated on removal #2305
  • Infinite recursion in circular pure computeds #2154

New features:

  • Trusted Types support #2579
  • Preserve bigint and symbol in ko.toJS #2612

TypeScript:

  • Type information lost when retrieving Subscribable<T> value #2555
  • Separate readonly and writable computed types (ReadonlyObservable, ReadonlyObservableArray, ReadonlyComputed) #2482
Commits
  • 08b71e1 Version 3.5.3 for distribution
  • f317d20 Merge pull request #2625 from knockout/fix/indirect-eval-strict-mode
  • 0a2bec0 Add strict mode e2e tests; refactor e2e runner
  • 14ea205 Use indirect eval for binding expressions (#2624)
  • 466602c Fix TypeScript types: Computed assignable to Subscribable (#2623)
  • 785e5ef Bump versions
  • e5aa17f Prevent infinite recursion in circular pureComputeds (fixes #2154)
  • 3a6a693 Fix foreach disposal ordering and reentrancy (fixes #2305)
  • db45fc9 Handle null/undefined array in checked binding (fixes #2309)
  • 463d387 Remove event handlers on node disposal (fixes #2314)
  • Additional commits viewable in compare view

@otto-the-bot otto-the-bot enabled auto-merge March 29, 2026 14:05
@zskhan
Copy link
Copy Markdown
Contributor

zskhan commented Apr 8, 2026

@dependabot rebase

@dependabot
chore: bump knockout from 3.5.1 to 3.5.3
68c34f4 
Bumps [knockout](https://github.com/knockout/knockout) from 3.5.1 to 3.5.3.
- [Release notes](https://github.com/knockout/knockout/releases)
- [Commits](knockout/knockout@v3.5.1...v3.5.3)

---
updated-dependencies:
- dependency-name: knockout
  dependency-version: 3.5.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/knockout-3.5.3 branch from dad51a0 to 68c34f4 Compare April 8, 2026 21:40
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zskhan
Copy link
Copy Markdown
Contributor

zskhan commented Apr 8, 2026

Knockout recently release after 6 years and introduced type strictness which needs a lot of refactoring on our end.
I am closing this PR for now as we are not going to touch KO related stuff before Kalium.

@zskhan zskhan closed this Apr 8, 2026
auto-merge was automatically disabled April 8, 2026 21:55

Pull request was closed

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Apr 8, 2026

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/knockout-3.5.3 branch April 8, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@arjita-mitra arjita-mitra Awaiting requested review from arjita-mitra arjita-mitra is a code owner

@e-maad e-maad Awaiting requested review from e-maad e-maad is a code owner

@nkaramarko nkaramarko Awaiting requested review from nkaramarko nkaramarko is a code owner

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

@screendriver screendriver Awaiting requested review from screendriver screendriver is a code owner

@thisisamir98 thisisamir98 Awaiting requested review from thisisamir98 thisisamir98 is a code owner

@V-Gira V-Gira Awaiting requested review from V-Gira V-Gira is a code owner

@zskhan zskhan Awaiting requested review from zskhan zskhan is a code owner

Assignees

No one assigned

Labels

app: webapp 👕 size: S type: chore 🧹

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zskhan @otto-the-bot