Merged
Conversation
kridai
reviewed
Apr 9, 2026
Contributor
kridai
left a comment
kridai
left a comment
There was a problem hiding this comment.
Please add description with details. Also ensure test coverage is there in sonar
Contributor
Author
The ResourceDeleter class is abstract class, for which we cannot write test cases |
Contributor
we can add tests, see https://github.com/twilio/twilio-java/blob/main/src/test/java/com/twilio/base/PatcherTest.java. We just need to define a stub class to inherit in test |
sbansla
approved these changes
Apr 9, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.