Skip to content

feat(wallet-connect): support#1756

Merged
it09 merged 12 commits intomainfrom
1698-wallet-connect
Mar 26, 2026
Merged

feat(wallet-connect): support#1756
it09 merged 12 commits intomainfrom
1698-wallet-connect

Conversation

@aigerimu
Copy link
Copy Markdown
Contributor

@aigerimu aigerimu commented Jan 17, 2026

closes #1698

Summary by CodeRabbit

  • Documentation
    • Added comprehensive WalletConnect integration documentation for institutional and custodial integrators on TON
    • Provides step-by-step setup instructions, configuration examples, and metadata requirements
    • Clarifies limitations and best practices—WalletConnect is unavailable in Telegram Mini Apps; TON Connect is recommended instead

@aigerimu aigerimu requested a review from novusnota January 17, 2026 12:28
@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the WalletConnect documentation; in ecosystem/ton-connect/wallet-connect.mdx: I’ve left a couple of suggestions, so please apply the inline suggestions to align the example configuration structure and wording with the docs style.

Copy link
Copy Markdown
Collaborator

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid! Left some comments that can improve this further.

aigerimu and others added 2 commits January 19, 2026 14:41
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
@github-actions

This comment has been minimized.

Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
@github-actions

This comment has been minimized.

novusnota
novusnota previously approved these changes Jan 19, 2026
Copy link
Copy Markdown
Collaborator

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! I'm giving a tentative approval pending confirmations from the involved parties.

DO NOT MERGE before those are received :)

@novusnota novusnota added the 3p Reviewed by someone else (a third party). Used for filtering PRs. Don't mind this. label Jan 21, 2026
@it09 it09 requested review from a team, TrueCarry and thekiba as code owners March 26, 2026 13:23
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

📝 Walkthrough

Walkthrough

Added WalletConnect support documentation to the TON Connect ecosystem section, including a new navigation entry in docs.json and a dedicated documentation page covering WalletConnect compatibility, integration steps, and platform limitations.

Changes

Cohort / File(s) Summary
WalletConnect Documentation
docs.json, ecosystem/ton-connect/wallet-connect.mdx
Added new navigation entry and documentation page for WalletConnect support, including integration instructions with TypeScript code examples, explicit limitations (unavailable in Telegram Mini Apps), and guidance for institutional/custodial integrators.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • thekiba
  • TrueCarry
  • novusnota

Poem

🐰 Hops with glee through docs anew
WalletConnect paths bloom in view,
For custodians seeking wider ways,
Beyond Telegram's bounded days,
Integration guides lead integrators true! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'feat(wallet-connect): support' is vague and generic, using non-descriptive language that doesn't clearly convey the specific nature of the changes (adding documentation for WalletConnect support). Make the title more descriptive, e.g., 'docs: add WalletConnect integration documentation' to clearly indicate this is a documentation addition.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The PR implements all five key requirements from issue #1698: explains why WalletConnect exists [#1698], specifies where it can be used [#1698], documents limitations for Telegram Mini Apps [#1698], provides high-level integration explanation [#1698], and includes integration examples with TypeScript code [#1698].
Out of Scope Changes check ✅ Passed All changes are directly scoped to issue #1698: the navigation entry and documentation page focus exclusively on WalletConnect support for non-Telegram applications with no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 1698-wallet-connect

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (2)
ecosystem/ton-connect/wallet-connect.mdx (2)

41-54: Consider extracting configuration values for clarity.

The example inlines configuration values directly in the function call. While this works, extracting these as top-level constants would make them easier to identify and modify, improving the example's maintainability. This aligns with documentation best practices for runnable examples.

♻️ Suggested refactor
import { initializeWalletConnect } from '@tonconnect/sdk';
import { UniversalConnector } from '@reown/appkit-universal-connector';

const PROJECT_ID = 'YOUR_PROJECT_ID';
const APP_METADATA = {
    name: 'My DApp',
    description: 'Example DApp',
    url: 'https://mydapp.com',
    icons: ['https://mydapp.com/icon.png']
};

initializeWalletConnect(UniversalConnector, {
    projectId: PROJECT_ID,
    metadata: APP_METADATA
});
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@ecosystem/ton-connect/wallet-connect.mdx` around lines 41 - 54, Extract the
inline config values into top-level constants so the example is clearer and
easier to modify: create constants (e.g., PROJECT_ID and APP_METADATA) and
assign the projectId string and metadata object respectively, then call
initializeWalletConnect(UniversalConnector, { projectId: PROJECT_ID, metadata:
APP_METADATA }); this keeps the original functions/symbols
(initializeWalletConnect, UniversalConnector) unchanged while improving
readability and maintainability.

32-32: Clarify the conditional statement.

The phrase "If required" is ambiguous. It's unclear whether this refers to requiring WalletConnect functionality or requiring wallet connection in general. Consider being more explicit.

📝 Suggested clarification
-If required, use [TON Connect](/ecosystem/ton-connect/overview) instead.
+For wallet connection functionality in these environments, use [TON Connect](/ecosystem/ton-connect/overview) instead.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@ecosystem/ton-connect/wallet-connect.mdx` at line 32, Replace the ambiguous
sentence "If required, use [TON Connect](/ecosystem/ton-connect/overview)
instead." with a specific condition that explains when to prefer TON Connect
(e.g., "If your app needs a full TON-native wallet integration or features not
supported by WalletConnect, use [TON Connect](/ecosystem/ton-connect/overview)
instead.") — update the text near that exact sentence in wallet-connect.mdx so
the reader clearly understands whether the requirement is about WalletConnect
limitations, specific features, or full TON-native integration.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@ecosystem/ton-connect/wallet-connect.mdx`:
- Around line 34-54: Add a brief changelog/version note above the "How to
integrate" section stating which TON Connect SDK version introduced
WalletConnect support and include a link to the SDK changeset; update the
documentation near the initializeWalletConnect/UniversalConnector example to
read something like "WalletConnect support was added in TON Connect SDK version
X.Y.Z — see [changelog](URL) for details" so readers know version compatibility
and can follow the linked changeset.
- Line 30: Edit the sentence "Due to Telegram policies, WalletConnect is not
supported in applications within, such as [Telegram Mini
Apps](/ecosystem/tma/overview)." by removing the unnecessary word "within" so it
reads "Due to Telegram policies, WalletConnect is not supported in applications,
such as [Telegram Mini Apps](/ecosystem/tma/overview)." ensuring punctuation and
spacing remain correct.
- Line 25: The WalletKit link currently points to
'/ecosystem/ton-connect/walletkit/overview' which triggers a redirect; update
the link target in the text that reads "Most applications and wallets should
continue to rely on [TON Connect](/ecosystem/ton-connect/overview) and
[WalletKit](/ecosystem/ton-connect/walletkit/overview)" to use the direct path
'/ecosystem/walletkit/overview' so the WalletKit reference avoids the redirect.

---

Nitpick comments:
In `@ecosystem/ton-connect/wallet-connect.mdx`:
- Around line 41-54: Extract the inline config values into top-level constants
so the example is clearer and easier to modify: create constants (e.g.,
PROJECT_ID and APP_METADATA) and assign the projectId string and metadata object
respectively, then call initializeWalletConnect(UniversalConnector, { projectId:
PROJECT_ID, metadata: APP_METADATA }); this keeps the original functions/symbols
(initializeWalletConnect, UniversalConnector) unchanged while improving
readability and maintainability.
- Line 32: Replace the ambiguous sentence "If required, use [TON
Connect](/ecosystem/ton-connect/overview) instead." with a specific condition
that explains when to prefer TON Connect (e.g., "If your app needs a full
TON-native wallet integration or features not supported by WalletConnect, use
[TON Connect](/ecosystem/ton-connect/overview) instead.") — update the text near
that exact sentence in wallet-connect.mdx so the reader clearly understands
whether the requirement is about WalletConnect limitations, specific features,
or full TON-native integration.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dec61925-f2ae-4c8e-b1a1-a38530aebeb3

📥 Commits

Reviewing files that changed from the base of the PR and between 016a9bc and 840104a.

⛔ Files ignored due to path filters (1)
  • resources/images/ton-connect/wallet-connect.png is excluded by !**/*.png
📒 Files selected for processing (2)
  • docs.json
  • ecosystem/ton-connect/wallet-connect.mdx

@it09 it09 merged commit db73a31 into main Mar 26, 2026
19 checks passed
@it09 it09 deleted the 1698-wallet-connect branch March 26, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3p Reviewed by someone else (a third party). Used for filtering PRs. Don't mind this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Ecosystem > TON Connect > WalletConnect support for non-Telegram applications]

4 participants