Skip to content

Silence various sass deprecation warnings#1212

Merged
cbutcosk merged 2 commits intomainfrom
fix/sass-deprecations
Apr 10, 2026
Merged

Silence various sass deprecation warnings#1212
cbutcosk merged 2 commits intomainfrom
fix/sass-deprecations

Conversation

@cbutcosk
Copy link
Copy Markdown
Collaborator

This PR restages #1129 against main's rewound commit history.

@cbutcosk cbutcosk force-pushed the fix/sass-deprecations branch from d4518b1 to ddb692c Compare April 6, 2026 19:12
@geealbers
Copy link
Copy Markdown
Member

@cbutcosk Oddly, this seems to have brought back SASS deprecation warnings that I wasn't seeing when testing PR #1210 and #1211?

@geealbers
Copy link
Copy Markdown
Member

@cbutcosk This is weird. It works fine on macOS but on Windows I'm running into what I think should be an unrelated error when running quire preview and one I didn't run into when testing the last two PRs:

[11ty] Copied 114 Wrote 0 files in 12.03 seconds (v3.1.0)
[11ty] Eleventy Fatal Error (CLI):
[11ty] 1. Having trouble writing to "./_site/about/index.html" from "./content/about.md" (via EleventyTemplateError)
[11ty] 2. Transform `@11ty/eleventy/html-transformer` encountered an error when transforming ./content/about.md. (via EleventyTransformError)
[11ty] 3. You have more than one HTML `id` attribute using the same value (id="section-learn-more") in your template (./content/about.md). You can disable this error in the IdAttribute plugin with the `checkDuplicates: false` option.
[11ty]
[11ty] Original error stack trace: Error: You have more than one HTML `id` attribute using the same value (id="section-learn-more") in your template (./content/about.md). You can disable this error in the IdAttribute plugin with the `checkDuplicates: false` option.
[11ty]     at file:///C:/Users/geeal/test-pr-1212/node_modules/@11ty/eleventy/src/Plugins/IdAttributePlugin.js:69:15
[11ty]     at C:\Users\geeal\test-pr-1212\node_modules\posthtml\lib\api.js:85:52

I started the test project with:

quire new test-pr-1212 --quire-path C:\Users\geeal\Downloads\quire\packages\11ty

The id="section-learn-more" the error message is referencing is coming from an accordion shortcode on the about.md page. Setting checkDuplicates: false in .eleventy.js does clear the error and at that point I can see that the SASS deprecation warnings have been properly silenced. Thoughts?

@cbutcosk
Copy link
Copy Markdown
Collaborator Author

cbutcosk commented Apr 10, 2026

@geealbers Hmm I don't see that problem on virtualized windows when I test it and it's passing on actual windows in CI. Furthermore if I recall those attributes should now be prefixed with epub- / pdf- or possibly written out (can't recall off hand).

We've used this branch name before, I wonder if your clone is outdated... When you have fix/sass-deprecations checked out could you try git reset --hard origin/fix-sass-deprecations and making a new publication as you had been? And / or try a fresh clone of the repo (checked out to the right branch) for passing in to quire new --quire-path ...?

Copy link
Copy Markdown
Member

@geealbers geealbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg, so dumb of me. I npm linked to the wrong copy of the quire repo on my tester PC. Thank you for the clue that got me to realize that. Now that I'm on the correct version, I can confirm this PR works as intended and can be merged. Thanks!

@cbutcosk cbutcosk merged commit bbcb372 into main Apr 10, 2026
6 checks passed
@cbutcosk cbutcosk deleted the fix/sass-deprecations branch April 10, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants