diff --git a/Sources/SkipScript/Skip/skip.yml b/Sources/SkipScript/Skip/skip.yml index 90a7089..a036c98 100644 --- a/Sources/SkipScript/Skip/skip.yml +++ b/Sources/SkipScript/Skip/skip.yml @@ -18,8 +18,8 @@ build: - block: 'dependencies' contents: # JSC is now on Maven central (https://github.com/facebook/react-native/pull/47972): https://repo1.maven.org/maven2/io/github/react-native-community/jsc-android/2026004.0.1/ - - 'implementation("io.github.react-native-community:jsc-android:2026004.0.1")' # 26.9 MB - #- 'implementation("io.github.react-native-community:jsc-android-intl:2026004.0.1")' # international version: 53.7 MB + #- 'implementation("io.github.react-native-community:jsc-android:2026004.0.1")' # 26.9 MB + - 'implementation("io.github.react-native-community:jsc-android-intl:2026004.0.1")' # international version: 53.7 MB - 'implementation("com.facebook.fbjni:fbjni:0.7.0")' # needed for libc++_shared.so, else no symbol "_ZNSt6__ndk122__libcpp_verbose_abortEPKcz" #- 'implementation("org.webkit:android-jsc-cppruntime:r245459@aar")' diff --git a/Tests/SkipScriptTests/JSContextTests.swift b/Tests/SkipScriptTests/JSContextTests.swift index 93cfef9..dd28000 100644 --- a/Tests/SkipScriptTests/JSContextTests.swift +++ b/Tests/SkipScriptTests/JSContextTests.swift @@ -81,9 +81,6 @@ class JSContextTests : XCTestCase { } func testIntl() throws { - // the Skip side uses jsc-android rather than jsc-android-intl for size savings - // TODO: provide a separate SkipScriptIntl target that depends on jsc-android-intl - #if !SKIP let ctx = try XCTUnwrap(JSContext()) XCTAssertEqual("12,34 €", ctx.evaluateScript("new Intl.NumberFormat('de-DE', { style: 'currency', currency: 'EUR' }).format(12.34)")?.toString()) @@ -104,7 +101,6 @@ class JSContextTests : XCTestCase { XCTAssertEqual("10/24/2022", ctx.evaluateScript("new Intl.DateTimeFormat('en-US', {timeZone: 'UTC'}).format(new Date('2022-10-24'))")?.toString()) XCTAssertEqual("24/10/2022", ctx.evaluateScript("new Intl.DateTimeFormat('fr-FR', {timeZone: 'UTC'}).format(new Date('2022-10-24'))")?.toString()) - #endif } func testProxy() throws {