diff --git a/src/v/cloud_io/tests/db_s3_imposter_fixture.cc b/src/v/cloud_io/tests/db_s3_imposter_fixture.cc index 345e0ed3f3e44..4cd59f51f5f85 100644 --- a/src/v/cloud_io/tests/db_s3_imposter_fixture.cc +++ b/src/v/cloud_io/tests/db_s3_imposter_fixture.cc @@ -125,7 +125,7 @@ struct db_s3_imposter_fixture::handler : ss::httpd::handler_base { rep->set_status(ss::http::reply::status_type::bad_request); } - rep->done("xml"); + rep->set_content_type("xml"); co_return std::move(rep); } diff --git a/src/v/http/tests/utils.cc b/src/v/http/tests/utils.cc index 13a4352fe97ac..fc6b2a410333c 100644 --- a/src/v/http/tests/utils.cc +++ b/src/v/http/tests/utils.cc @@ -45,16 +45,15 @@ ss::future> flexible_function_handler::handle( .then([this](std::unique_ptr rep) { if ( _content_type_overrides.contains(rep->get_header("Content-Type"))) { - rep->done(); + // content type already set via override; nothing to do } else if (_content_type == "xml") { // Because `application/xml` is not implemented as a mapping // in `http/mime_types.cc`, in order to construct a reply with // the `Content-Type` header set to `application/xml`, we // need to hard code a path here. rep->set_content_type("application/xml"); - rep->done(); } else { - rep->done(_content_type); + rep->set_content_type(_content_type); } return ss::make_ready_future>( std::move(rep)); diff --git a/src/v/redpanda/admin/server.cc b/src/v/redpanda/admin/server.cc index 622c783580424..ffc249301856c 100644 --- a/src/v/redpanda/admin/server.cc +++ b/src/v/redpanda/admin/server.cc @@ -397,7 +397,6 @@ class rpc_handler : public ss::httpd::handler_base { std::current_exception()); rep = serde::pb::rpc::internal_exception().handle(std::move(rep)); } - rep->done(); co_return rep; }