fix: ensure separator boundary in allowFsRead wildcard check#3967
Open
fg0x0 wants to merge 1 commit intoparallax:masterfrom
Open
fix: ensure separator boundary in allowFsRead wildcard check#3967fg0x0 wants to merge 1 commit intoparallax:masterfrom
fg0x0 wants to merge 1 commit intoparallax:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch addresses the path prefix confusion in the allowFsRead wildcard handling reported via security disclosure.
The original condition checked whether fixedPart ended with path.sep before appending a separator to resolved. On Windows, path.sep is a backslash, but wildcard patterns are typically written with forward slashes (e.g. ./fonts/*), so the condition was never true and no separator was appended.
The fix removes the fixedPart check entirely. Since path.resolve() already normalizes the separator to the OS-native character, checking resolved alone is both sufficient and correct on all platforms.