Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
e6924cd to
cb31745
Compare
.github/workflows/release.yml
Outdated
| repo: ${{ fromJSON(needs.determine-release-type.outputs.docker_repos) }} | ||
| steps: | ||
| - run: | | ||
| curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/install.sh | sh -s -- -b /usr/local/bin |
There was a problem hiding this comment.
⛔ use the github action fro trivy
There was a problem hiding this comment.
I copy pasted trivy image and SHA: The action aquasecurity/trivy-action@57a97c7e7821a5776cebc9bb87c984fa69cba8f1 # v0.35.0
from
https://github.com/owncloud-docker/ubuntu/blob/1ade6e6489ab7c5f44496cd5405a1f932229a3ec/.github/workflows/docker-build.yml#L62
But Github complains:
The action aquasecurity/trivy-action@57a97c7 is not allowed in owncloud/ocis
https://github.com/owncloud/ocis/actions/runs/24236341605
.github/workflows/release.yml
Outdated
| matrix: | ||
| repo: ${{ fromJSON(needs.determine-release-type.outputs.docker_repos) }} | ||
| steps: | ||
| - run: echo "${{ secrets.DOCKER_PASSWORD }}" | docker login -u "${{ secrets.DOCKER_USERNAME }}" --password-stdin |
| - run: echo "${{ secrets.DOCKER_PASSWORD }}" | docker login -u "${{ secrets.DOCKER_USERNAME }}" --password-stdin | ||
| - if: ${{ contains(matrix.repo, 'rolling') }} | ||
| run: | | ||
| docker buildx imagetools create \ |
There was a problem hiding this comment.
⛔ use docker/build-push-actio
.github/workflows/release.yml
Outdated
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| - run: | | ||
| README=$(python3 -c "import sys,json; print(json.dumps(sys.stdin.read()))" < ocis/docker/README.md) |
There was a problem hiding this comment.
⛔ use peter-evans/dockerhub-description
.github/workflows/release.yml
Outdated
| path: . | ||
| - run: | | ||
| [[ "${{ needs.determine-release-type.outputs.is_prerelease }}" == "true" ]] && PRERELEASE=--prerelease | ||
| gh release create -R "${{ github.repository }}" "${{ needs.determine-release-type.outputs.version }}" \ |
There was a problem hiding this comment.
also pre defined actions do exist for that
097566c to
1fe0395
Compare
a6106d7 to
fb53d24
Compare
Release Expected State
Reference release: v8.0.1
1. GitHub Release page
tag_namev{VERSION}name{VERSION}(novprefix)draftfalseprereleasefalsefor stable,trueif version contains-target_commitishmaster(or active stable branch)2. Release assets — exact file set (14 files)
3. Binary file checks
ELF 64-bit x86-64ELF 64-bit aarch64ELF 32-bit ARMELF 32-bit Intel 80386Mach-O 64-bit x86_64Mach-O 64-bit arm644.
.sha256file checks.sha256file is 87–90 bytes{sha256hash} {filename}(two spaces, standardsha256sumoutput)sha256sumof the corresponding binary5.
third-party-licenses.tar.gzfilereportsgzip compressed data)6. EULA PDF
filereportsPDF document)End-User-License-Agreement-for-ownCloud-Infinite-Scale.pdf7. Docker images (production release only)
owncloud/ocis-rolling{VERSION},{MAJOR}.{MINOR},{MAJOR}owncloud/ocis{VERSION},{MAJOR}.{MINOR},{MAJOR}Verify:
docker buildx imagetools inspect owncloud/ocis:{VERSION} # must show linux/amd64 and linux/arm64 manifests8. Git tag
git tag -v v{VERSION} # must be a signed tag git cat-file -p v{VERSION} | grep "^object" # must point to a commit on master9. Release content audit
scripts/audit-release.pyChecklist: