Open
Conversation
embetrix
force-pushed
the
feature/leancrypto
branch
3 times, most recently
from
a130020 to
ef379b3
Compare
Contributor
|
Regarding the tests, do you think you could make them ptest compatible? That would allow them to be executed regularly, helping with regressions. (Also, extra thanks a lot for the tests, they are always useful, and that is especially true for cryptography tools) |
Contributor
Author
|
@OldManYellsAtCloud Thanks for the review. Implementing this would require additional effort and I can’t commit to it right now. However this could be considered as part of a future improvement in a separate pull request. |
Contributor
|
the recipe fails to build, see - https://autobuilder.yoctoproject.org/valkyrie/api/v2/logs/5867436/raw_inline |
embetrix
force-pushed
the
feature/leancrypto
branch
from
ef379b3 to
cdcb222
Compare
Contributor
Author
|
@kraj thanks for checking, I added |
Contributor
This sort of papers over the underlying problem but it does impact reproducible builds, which we are aggressively trying to achieve for meta-oe layers. I would expect a root cause and fix in the build scripts to not let the hard coding show up in ELF files. It might be some cflags/ldfags etc getting it wrong. |
Contributor
Author
|
@kraj only test programs |
Cryptographic library that exclusively contains Quantum resistant cryptographic algorithms. It is lean has minimal dependencies, supports stack-only operation and provides optimized implementations for ML-KEM (Kyber), ML-DSA (Dilithium), SLH-DSA (Sphincs+) and many more Signed-off-by: Ayoub Zaki <ayoub.zaki@embetrix.com>
embetrix
force-pushed
the
feature/leancrypto
branch
from
cdcb222 to
35cf3b0
Compare
Contributor
Author
|
@kraj I fixed the issue upstream, got quickly merged and imported the backport patch so it should pass now :-) |
kraj
requested changes
Mar 19, 2026
| PACKAGECONFIG[tests] = "-Dtests=enabled,-Dtests=disabled" | ||
|
|
||
| do_install:append () { | ||
| if ${@bb.utils.contains('PACKAGECONFIG', 'tests', 'true', 'false', d)}; then |
Contributor
There was a problem hiding this comment.
I think it would be better to use ptest distro feature to instrument the test related pieces of the recipe. Please check other recipes which inherit ptest and control it that way.
Contributor
|
it still is not through the build errors see https://autobuilder.yoctoproject.org/valkyrie/#/builders/81/builds/1363 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cryptographic library that exclusively contain Quantum resistant cryptographic algorithms. It is lean has minimal dependencies, supports stack-only operation and provides optimized implementations for ML-KEM (Kyber), ML-DSA (Dilithium), SLH-DSA (Sphincs+) and many more.