fix: ARenderer TypeError when href is undefined#32
Merged
jsamr merged 2 commits intonative-html:mainfrom Apr 14, 2026
Merged
Conversation
Fixes TypeError on `href.lenght` when href is undefined - tests `typeof href` is string before reading its length `useNormalizedUrl` can return `undefined` if it fails to parse absolute an url (see: normalizeResourceLocator.ts) > `[TypeError: Cannot read property 'length' of undefined]`
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 140 140
Lines 2083 2084 +1
Branches 633 634 +1
=======================================
+ Hits 2055 2056 +1
Misses 27 27
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Hi @arieloO, thanks for the contribution! |
jsamr
reviewed
Apr 13, 2026
- see fix: ARenderer TypeError when href is undefined (2c6f82a)
Collaborator
|
LGTM, let's wait for @jsamr to give the final approve |
jsamr
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TypeError on
href.lengthwhen href is undefinedtypeof hrefis string before reading its lengthuseNormalizedUrlcan returnundefinedif it fails to parse absolute an url (see: normalizeResourceLocator.ts)