Challenge 12: Verify safety of NonZero#565
Open
Samuelsills wants to merge 1 commit intomodel-checking:mainfrom
Open
Challenge 12: Verify safety of NonZero#565Samuelsills wants to merge 1 commit intomodel-checking:mainfrom
Samuelsills wants to merge 1 commit intomodel-checking:mainfrom
Conversation
Samuelsills
force-pushed
the
challenge-12-nonzero
branch
3 times, most recently
from
938fdd1 to
32bbacc
Compare
Verify all 38 NonZero functions listed in the challenge specification. 432 Kani proof harnesses across all 12 integer types, 0 failures. Resolves model-checking#71 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
Samuelsills
force-pushed
the
challenge-12-nonzero
branch
from
32bbacc to
71e54d0
Compare
Author
Verification Coverage ReportPart 1:
|
| # | Function | Verified | # | Function | Verified |
|---|---|---|---|---|---|
| 1 | max |
✅ | 19 | saturating_add |
✅ |
| 2 | min |
✅ | 20 | unchecked_add |
✅ |
| 3 | clamp |
✅ | 21 | checked_next_power_of_two |
✅ |
| 4 | bitor (3 impls) |
✅ | 22 | midpoint |
✅ |
| 5 | count_ones |
✅ | 23 | isqrt |
✅ |
| 6 | rotate_left |
✅ | 24 | abs |
✅ |
| 7 | rotate_right |
✅ | 25 | checked_abs |
✅ |
| 8 | swap_bytes |
✅ | 26 | overflowing_abs |
✅ |
| 9 | reverse_bits |
✅ | 27 | saturating_abs |
✅ |
| 10 | from_be |
✅ | 28 | wrapping_abs |
✅ |
| 11 | from_le |
✅ | 29 | unsigned_abs |
✅ |
| 12 | to_be |
✅ | 30 | checked_neg |
✅ |
| 13 | to_le |
✅ | 31 | overflowing_neg |
✅ |
| 14 | checked_mul |
✅ | 32 | wrapping_neg |
✅ |
| 15 | saturating_mul |
✅ | 33 | from_mut |
✅ |
| 16 | unchecked_mul |
✅ | 34 | from_mut_unchecked |
✅ |
| 17 | checked_pow |
✅ | |||
| 18 | saturating_pow |
✅ | |||
| — | neg |
✅ | — | checked_add |
✅ |
Total: 38/38 functions verified (2 Part 1 + 36 Part 2)
UBs Checked
- ✅ Invoking UB via compiler intrinsics
- ✅ Reading from uninitialized memory
- ✅ Producing an invalid value
Verification Approach
- Tool: Kani Rust Verifier
- 432 proof harnesses across all 12 NonZero integer types
- Verified for all NonZero types (i8, u8, i16, u16, i32, u32, i64, u64, i128, u128, isize, usize)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verify all 38 NonZero functions listed in Challenge 12. 432 Kani proof harnesses across all 12 integer types, 0 failures.
Part 1: Harnesses for
new(iff + value equality assertions) andfrom_mut(iff + dereference). Pre-existing contracts and harnesses fornew_uncheckedandfrom_mut_unchecked.Part 2: Harnesses for all 34 listed functions including bitor (3 impls), count_ones, rotate_left/right, swap_bytes, reverse_bits, endianness conversions, checked/saturating mul/pow/add, checked_next_power_of_two, midpoint, isqrt, abs variants (6), and neg variants (4).
Strengthened loop invariant on
checked_powinuint_macros.rsandint_macros.rsfromtrueto a property that preserves the nonzero invariant through loop iterations. This is a verification-only annotation (no-op at runtime).absandnegharnesses excludeT::MIN(documented overflow behavior). The MIN case is separately verified bywrapping_abs,overflowing_abs,wrapping_neg, andoverflowing_negwhich pass for all inputs.Resolves #71
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.