[windows-registry] Key.get_bytes() removed

[zanedp]

Summary

In #3184, Key.get_bytes() was removed, but other safe getters were left in, making me think get_bytes() was removed accidentally.

[riverar]

@zanedp Can you add a bit more detail to your issue?

[zanedp]

Before #3184, Key had a get_bytes() method:

windows-rs/crates/libs/registry/src/key.rs

Line 325 in 62ccc94

pub fn get_bytes<T: AsRef<str>>(&self, name: T) -> Result<Vec<u8>> {

After #3184, it has raw_get_bytes(), and get_bytes() is gone, but other safe getters are still present. The other safe getters still being present makes me wonder if removing get_bytes() may have been unintentional.

Safe getters that remain in Key:

windows-rs/crates/libs/registry/src/key.rs

Line 153 in 89d94b5

pub fn get_u32<T: AsRef<str>>(&self, name: T) -> Result<u32> {

windows-rs/crates/libs/registry/src/key.rs

Line 158 in 89d94b5

pub fn get_u64<T: AsRef<str>>(&self, name: T) -> Result<u64> {

windows-rs/crates/libs/registry/src/key.rs

Line 165 in 89d94b5

pub fn get_string<T: AsRef<str>>(&self, name: T) -> Result<String> {

windows-rs/crates/libs/registry/src/key.rs

Line 170 in 89d94b5

pub fn get_hstring<T: AsRef<str>>(&self, name: T) -> Result<HSTRING> {

windows-rs/crates/libs/registry/src/key.rs

Line 185 in 89d94b5

pub fn get_multi_string<T: AsRef<str>>(&self, name: T) -> Result<Vec<String>> {

The work arounds are to use unsafe raw_get_bytes() or to use key.get_value(name).to_vec().