From cac48c07d364bb344abb6583f1618b7e2e825b3b Mon Sep 17 00:00:00 2001 From: Jorge Rangel Date: Fri, 13 Mar 2026 17:52:15 -0500 Subject: [PATCH] fix: add semver dep to publish pipeline --- packages/http-client-csharp/eng/pipeline/publish.yml | 4 ++++ .../http-client-csharp/eng/scripts/Update-PackageJson.ps1 | 7 +++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/http-client-csharp/eng/pipeline/publish.yml b/packages/http-client-csharp/eng/pipeline/publish.yml index 37e8b562677..6a919676073 100644 --- a/packages/http-client-csharp/eng/pipeline/publish.yml +++ b/packages/http-client-csharp/eng/pipeline/publish.yml @@ -152,6 +152,10 @@ extends: npm install -g @azure-tools/typespec-client-generator-cli@latest displayName: Install tsp-client + - pwsh: | + npm install -g semver + displayName: Install semver + - task: PowerShell@2 displayName: Update package.json with injected dependencies inputs: diff --git a/packages/http-client-csharp/eng/scripts/Update-PackageJson.ps1 b/packages/http-client-csharp/eng/scripts/Update-PackageJson.ps1 index 51b800093f7..d380b73361e 100644 --- a/packages/http-client-csharp/eng/scripts/Update-PackageJson.ps1 +++ b/packages/http-client-csharp/eng/scripts/Update-PackageJson.ps1 @@ -112,10 +112,9 @@ function Test-TcgcCompatibility { $tcgcRange = ($tcgcRange | Out-String).Trim() Write-Host " Requires tcgc: $tcgcRange" - $jsCode = "try{console.log(require('semver').satisfies('$TcgcVersion','$tcgcRange'))}catch(e){console.log('error')}" - $semverResult = (& node -e $jsCode 2>&1 | Out-String).Trim() + $semverResult = & npx semver -r $tcgcRange $TcgcVersion 2>&1 - if ($semverResult -eq 'true') { + if ($LASTEXITCODE -eq 0 -and $semverResult) { Write-Host " ✓ Compatible" return $true } else { @@ -295,4 +294,4 @@ try { catch { Write-Error "Script failed with error: $_" exit 1 -} \ No newline at end of file +}