From 5208ed98305607df5d886d0623a094212b285414 Mon Sep 17 00:00:00 2001 From: Holger Benl Date: Mon, 16 Mar 2026 13:07:58 +0100 Subject: [PATCH] test(bidi): wait for dialog to be dismissed in beforeunload test --- tests/library/beforeunload.spec.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/library/beforeunload.spec.ts b/tests/library/beforeunload.spec.ts index c8e2ce30a8cdf..78c5a73d52307 100644 --- a/tests/library/beforeunload.spec.ts +++ b/tests/library/beforeunload.spec.ts @@ -195,7 +195,9 @@ it('does not get stalled by beforeUnload', { event.preventDefault(); }); }); - page.on('dialog', dialog => dialog.dismiss()); + const dialogDismissed = new Promise(resolve => { + page.on('dialog', dialog => dialog.dismiss().then(() => resolve())); + }); // We have to interact with a page so that 'beforeunload' handlers // fire. @@ -207,4 +209,6 @@ it('does not get stalled by beforeUnload', { await page.close({ runBeforeUnload: true }); await page.evaluate(async () => fetch(new URL('/api', window.location.href))); + + await dialogDismissed; });