[MOO-2266] : fix bottom sheet to avoid app crash#482
Open
Conversation
SrirangK
force-pushed
the
moo/MOO-2266-bottom-sheet-fix
branch
from
dced1fa to
22fd283
Compare
Contributor
There was a problem hiding this comment.
Looks like bottom padding is somehow ignored/not added in new screenshot. Can you check if there is/was any code snippet related to status bar height or safe area padding?
| - extendedWaitUntil: | ||
| visible: randText | ||
| optional: true | ||
| timeout: 50000 |
Contributor
There was a problem hiding this comment.
Huge jump from 10 seconds to 50 check why it is taking additional time to appear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅This PR contains
What is the purpose of this PR?
Fix the issue in bottom sheet avoiding crash in application
Relevant changes
The crash was caused by unstable (re-created every render) function and array references being passed to @gorhom/bottom-sheet, which internally relies on reference equality for optimization. The fix stabilizes all these references using useCallback/useMemo.