fix: bypass subdomain validation when agents_url is configured for self-hosted deployments#803
Open
j0nscalet wants to merge 1 commit intolivekit:mainfrom
Open
fix: bypass subdomain validation when agents_url is configured for self-hosted deployments#803j0nscalet wants to merge 1 commit intolivekit:mainfrom
j0nscalet wants to merge 1 commit intolivekit:mainfrom
Conversation
Self-hosted deployments with custom domains (e.g. livekit.example.com) cannot use lk agent commands because the subdomain extracted from the project URL never matches the livekit.toml subdomain field. Add agents_url to LiveKitTOMLAgentConfig and skip subdomain validation when it is explicitly set, applying it as LK_AGENTS_URL instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
LK_AGENTS_URLis set, subdomain validation should be skipped — butlk agent deployalways runs it first, making the override ineffective:Fix
Add
agents_urltoLiveKitTOMLAgentConfig. When set, skip subdomain validation in the deploy path and apply it asLK_AGENTS_URLbeforecloudagents.New()is called.Relates to #758.