notification: Limit max height and enable vscroll#13640
Open
anaximeno wants to merge 1 commit intolinuxmint:masterfrom
Open
notification: Limit max height and enable vscroll#13640anaximeno wants to merge 1 commit intolinuxmint:masterfrom
anaximeno wants to merge 1 commit intolinuxmint:masterfrom
Conversation
anaximeno
changed the title
Disable vfade, looks a bit bad with the default Mint-Y theme in the notification component.
anaximeno
force-pushed
the
notification/set-max-min-height-and-enable-vscroll
branch
from
5a12fa0 to
8306b83
Compare
anaximeno
changed the title
Member
|
I think this is good for a notification's initial display, but maybe the max height can be increased, or even based on some percentage of the monitor height. Once it's in the notification applet, however, it should revert to its full size and remove the individual scrolling altogether - I think the parent being scrollable there is enough, and having both is confusing (scroll works for the outer but not the inner). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids cases where notifications would grow beyond the monitor screen height.
Before
After