Remove backwards-compatible authentication config in 0.7.0

[raballew]

TODO Comment

// TODO: remove in 0.7.0

Location

• controller/internal/config/config.go, line 73
• controller/deploy/helm/jumpstarter/charts/jumpstarter-controller/templates/cms/controller-cm.yaml, line 14

Context

config.go:

rawAuthenticationConfiguration, ok := configmap.Data["authentication"]
if ok {
    // backwards compatibility
    // TODO: remove in 0.7.0
    authenticator, prefix, err := oidc.LoadAuthenticationConfiguration(
        ctx,
        scheme,
        []byte(rawAuthenticationConfiguration),
        signer,
        certificateAuthority,
    )

controller-cm.yaml:

data:
  # backwards compatibility
  # TODO: remove in 0.7.0
  {{ if .Values.authenticationConfig }}
  authentication: {{- .Values.authenticationConfig | toYaml | indent 1 }}
  {{ end }}

Legacy authentication config key is kept for backwards compatibility and should be removed in version 0.7.0.

[ambient-code]

Fix Plan

The project is currently at v0.8.1 (past the 0.7.0 deadline), so it's time to remove the backwards-compatible authentication config key.

Changes:

1. controller/internal/config/config.go: Remove the backwards-compat block (lines 70-91) that checks for the legacy authentication key in the configmap and falls through to oidc.LoadAuthenticationConfiguration. After removal, only the new config key path will be used.
2. controller/deploy/helm/jumpstarter/charts/jumpstarter-controller/templates/cms/controller-cm.yaml: Remove the {{ if .Values.authenticationConfig }} block that renders the legacy authentication key in the ConfigMap.
3. controller/deploy/helm/jumpstarter/charts/jumpstarter-controller/values.schema.json: Remove the authenticationConfig property from the schema.
4. controller/deploy/helm/jumpstarter/charts/jumpstarter-controller/model.py: Remove the authenticationConfig field from the Model class.
5. controller/internal/oidc/config.go: Remove the now-unused LoadAuthenticationConfiguration function (only called from the backwards-compat path).
6. Clean up any unused imports resulting from the above changes.

Working on this now.

[ambient-code]

PR created: #537