Fix remaining issues

Author: kirkbrauer

packages/jumpstarter-kubernetes/jumpstarter_kubernetes/cluster/kind.py

@@ -64,7 +64,7 @@ async def create_kind_cluster(
 
     if cluster_exists:
         if not force_recreate:
-            raise RuntimeError(f"Kind cluster '{cluster_name}' already exists.")
+            raise ClusterAlreadyExistsError(cluster_name, "kind")
         else:
             if not await delete_kind_cluster(kind, cluster_name):
                 return False

packages/jumpstarter-kubernetes/jumpstarter_kubernetes/cluster/kind_test.py

@@ -10,6 +10,7 @@
     kind_cluster_exists,
     kind_installed,
 )
+from jumpstarter_kubernetes.exceptions import ClusterAlreadyExistsError
 
 
 class TestKindInstalled:
@@ -131,9 +132,12 @@ async def test_create_kind_cluster_already_exists(self, mock_cluster_exists, moc
         mock_kind_installed.return_value = True
         mock_cluster_exists.return_value = True
 
-        with pytest.raises(RuntimeError, match="Kind cluster 'test-cluster' already exists"):
+        with pytest.raises(ClusterAlreadyExistsError) as exc_info:
             await create_kind_cluster("kind", "test-cluster")
 
+        assert exc_info.value.cluster_name == "test-cluster"
+        assert exc_info.value.cluster_type == "kind"
+
     @pytest.mark.asyncio
     @patch("jumpstarter_kubernetes.cluster.kind.kind_installed")
     @patch("jumpstarter_kubernetes.cluster.kind.kind_cluster_exists")

packages/jumpstarter-kubernetes/jumpstarter_kubernetes/cluster/operations.py

@@ -154,6 +154,8 @@ async def create_cluster_and_install(
         await create_minikube_cluster_with_options(
             minikube, cluster_name, minikube_extra_args, force_recreate_cluster, extra_certs, callback
         )
+    else:
+        raise ClusterTypeValidationError(f"Unsupported cluster_type: {cluster_type}")
 
     # Install Jumpstarter if requested
     if install_jumpstarter:

packages/jumpstarter-kubernetes/jumpstarter_kubernetes/cluster/operations_test.py

@@ -170,3 +170,11 @@ async def test_create_cluster_and_install_no_version(self, mock_configure, mock_
 
         with pytest.raises(ClusterOperationError):
             await create_cluster_and_install("kind", False, "test-cluster", "", "", "kind", "minikube")
+
+    @pytest.mark.asyncio
+    async def test_create_cluster_and_install_unsupported_cluster_type(self):
+        """Test that creating a cluster with an unsupported cluster type raises ClusterTypeValidationError."""
+        with pytest.raises(ClusterTypeValidationError) as exc_info:
+            await create_cluster_and_install("remote", False, "test-cluster", "", "", "kind", "minikube")
+
+        assert "Unsupported cluster_type: remote" in str(exc_info.value)