test(infinite-scroll): stabilize top scroll test#31049
Closed
ManthanBhatt wants to merge 1 commit intoionic-team:mainfrom
Closed
test(infinite-scroll): stabilize top scroll test#31049ManthanBhatt wants to merge 1 commit intoionic-team:mainfrom
ManthanBhatt wants to merge 1 commit intoionic-team:mainfrom
Conversation
|
@ManthanBhatt is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30423
What is the current behavior?
The top-positioned infinite scroll test is flaky on CI with Safari and is currently skipped for WebKit. The test assumes a specific initial scroll state, which makes it timing-sensitive.
What is the new behavior?
The test now uses a deterministic scroll sequence by scrolling to the bottom first, waiting for the content to actually be offset, and then scrolling back to the top before waiting for
ionInfiniteComplete.Does this introduce a breaking change?
Other information
npx playwright test src/components/infinite-scroll/test/top/infinite-scroll.e2e.ts --project="Mobile Chrome"npx playwright test src/components/infinite-scroll/test/top/infinite-scroll.e2e.ts --project="Mobile Safari"npx eslint src/components/infinite-scroll/test/top/infinite-scroll.e2e.tspassed