refactor: update TypeScript to v6#409
Open
lumirlumir wants to merge 7 commits intomainfrom
Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
lumirlumir
added
accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
Note
This PR follows the same strategy used in eslint/json#224 and eslint/json#230.
This PR updates TypeScript to v6.
The following two changes mainly affected us during the upgrade to TypeScript v6.
strictmode is now the default.https://devblogs.microsoft.com/typescript/announcing-typescript-6-0/#simple-default-changes
rootdirnow defaults to.https://devblogs.microsoft.com/typescript/announcing-typescript-6-0/#rootdir-now-defaults-to-.
What changes did you make? (Give an overview)
I've tried to retain strict mode behavior as much as possible and only disabled it where it produced too many errors.
However, unlike the JSON and Markdown updates, the
noImplicitAnyoption produced too many errors to address in this PR, so I've turned it off in this case.Related Issues
Refs: eslint/json#224, eslint/json#230
Is there anything you'd like reviewers to focus on?
N/A