Allow per-pixel lighting to be changed at runtime#134
Closed
PJB3005 wants to merge 1 commit into
Closed
Conversation
Just make the constexpr part of the pipeline config instead, easy. Defaults to off, changed in GX state via new Aurora FIFO command.
Owner
|
I will land this next time I'm bumping the pipeline config version. Doesn't seem like worth a break on its own. In the meantime, I disabled per-pixel lighting globally |
Owner
|
Since per-pixel lighting is disabled for the foreseeable future, going to close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just make the constexpr part of the pipeline config instead, easy.
Defaults to off, changed in GX state via new Aurora FIFO command.