Dropped instructions from FBStaticAccessConverter

[csheinlen]

I've been debugging cases where instructions are getting dropped and came across ReplaceStaticAccess in DotNetSiemensPLCToolBoxLibrary.PLCs.S7_xxx.MC7.FBStaticAccessConverter .

public static void ReplaceStaticAccess(S7FunctionBlock myFct, S7ProgrammFolder myFld, S7ConvertingOptions myOpt)
{
    if (myOpt.ReplaceDIAccessesWithSymbolNames && myFct.BlockType==PLCBlockType.FB)
    {
        List<FunctionBlockRow> retVal = new List<FunctionBlockRow>();
        List<FunctionBlockRow> tempList = new List<FunctionBlockRow>();

        bool LargeAccess = false;
        int add_adresse = 0;

        foreach (var functionBlockRow in myFct.AWLCode)
        {
            if (functionBlockRow.Command == "TAR2")
            {
                tempList.Add(functionBlockRow);
                LargeAccess = true;
            }
            else if (functionBlockRow.Command == "+AR2" && LargeAccess)
            {
                tempList.Add(functionBlockRow);
                add_adresse += Convert.ToInt32(Convert.ToDouble(((S7FunctionBlockRow) functionBlockRow).Parameter.Substring(2), new NumberFormatInfo() {NumberDecimalSeparator = "."}));
            }
            else if (((S7FunctionBlockRow)functionBlockRow).Parameter.Contains("[AR2,P#") && ((S7FunctionBlockRow)functionBlockRow).Parameter.Substring(0, 2) == "DI" && !LargeAccess)
            {
                string para = ((S7FunctionBlockRow) functionBlockRow).Parameter;
                ByteBitAddress adr = new ByteBitAddress(para.Substring(10, para.Length - 11));
                var parRow = S7DataRow.GetDataRowWithAddress(myFct.Parameter, adr, true);
                if (parRow != null)
                {
                    byte[] tmp = ((S7FunctionBlockRow) functionBlockRow).MC7;
                    ((S7FunctionBlockRow) functionBlockRow).Parameter = "#" + parRow.StructuredName.Substring(parRow.StructuredName.IndexOf('.') + 1);
                    ((S7FunctionBlockRow) functionBlockRow).MC7 = tmp;
                }
                retVal.Add(functionBlockRow);
            }
            else if (((S7FunctionBlockRow)functionBlockRow).Parameter.Contains("[AR2,P#") && ((S7FunctionBlockRow)functionBlockRow).Parameter.Substring(0, 2) == "DI" && LargeAccess)
            {
                /*
                string para = ((S7FunctionBlockRow)functionBlockRow).Parameter;
                ByteBitAddress adr = new ByteBitAddress(para.Substring(10, para.Length - 11));
                adr.ByteAddress += add_adresse;
                var parRow = S7DataRow.GetDataRowWithAddress(myFct.Parameter, adr);
                if (parRow != null)
                {
                    byte[] tmp = ((S7FunctionBlockRow)functionBlockRow).MC7;
                    ((S7FunctionBlockRow)functionBlockRow).Parameter = "#" + parRow.StructuredName;
                    ((S7FunctionBlockRow)functionBlockRow).MC7 = tmp;
                }
                retVal.Add(functionBlockRow);
                */
                LargeAccess = false;
            }
            else if (functionBlockRow.Command == "LAR2")
            {

            }
            else
            {
                LargeAccess = false;
                retVal.AddRange(tempList);
                tempList.Clear();
                retVal.Add(functionBlockRow);
            }
        }

        myFct.AWLCode = retVal;
    }            

It looks like every LAR2 instruction gets dropped and any instruction containing DI[P#XX.XX] that immediately follows a TAR2 command gets dropped. It seems like LargeAccess is not being utilized as intended and the LAR2 branch was stubbed out and never completed. Is there some larger context that I'm missing and this behavior is intended?

[jogibear9988]

For sure there could be cases wich do not work....
Maybe I've never seen them in the code i used...
It's so long ago, so I'm not so deep into this any more...

Can you show some AWL Code what you mean wich gets wrongly converted?

But I think you need to work on a fix yourself and create a pull req.