diff --git a/src/gw2/cogs/sessions.py b/src/gw2/cogs/sessions.py index 15dd4aa..7828ca8 100644 --- a/src/gw2/cogs/sessions.py +++ b/src/gw2/cogs/sessions.py @@ -251,10 +251,7 @@ def _add_wvw_stats(embed: discord.Embed, rs_start: dict, rs_end: dict) -> None: end_val = rs_end[stat_key] if start_val != end_val: diff = end_val - start_val - if stat_key == "wvw_rank": - embed.add_field(name=field_name, value=chat_formatting.inline(str(diff))) - else: - embed.add_field(name=field_name, value=chat_formatting.inline(f"+{diff}" if diff > 0 else str(diff))) + embed.add_field(name=field_name, value=chat_formatting.inline(str(diff))) def _add_wallet_currency_fields(embed: discord.Embed, rs_start: dict, rs_end: dict) -> None: diff --git a/tests/unit/gw2/cogs/test_sessions.py b/tests/unit/gw2/cogs/test_sessions.py index 9ea69c1..8ad2fc7 100644 --- a/tests/unit/gw2/cogs/test_sessions.py +++ b/tests/unit/gw2/cogs/test_sessions.py @@ -944,12 +944,11 @@ def test_all_stats_changed(self): with patch("src.gw2.cogs.sessions.chat_formatting.inline", side_effect=lambda x: f"`{x}`"): _add_wvw_stats(embed, start, end) assert len(embed.fields) == 8 - # wvw_rank should not have + sign (rank can only increase) + # WvW stats should not have + sign (they can only increase) rank_field = next(f for f in embed.fields if f.name == gw2_messages.WVW_RANKS) assert rank_field.value == "`2`" - # other stats should have + sign yaks_field = next(f for f in embed.fields if f.name == gw2_messages.YAKS_KILLED) - assert yaks_field.value == "`+3`" + assert yaks_field.value == "`3`" def test_no_stats_changed(self): embed = discord.Embed()