IS-11275 LWA: viewName built-in UIs (first: BankID wait UI)#150
Open
aleixsuau wants to merge 4 commits into
Open
IS-11275 LWA: viewName built-in UIs (first: BankID wait UI)#150aleixsuau wants to merge 4 commits into
aleixsuau wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Introduces an opt-in “viewName built-in UIs” mechanism for HaapiStepperStepUI, with an initial built-in UI implementation for the BankID polling view (authenticator/bankid/wait/index) to improve UX (persistent polling spinner + QR link positioning).
Changes:
- Adds a viewName-to-built-in-UI registry (
getViewNameBuiltInUI, enum + map) and integrates it intoHaapiStepperStepUIbehind theenableViewNameBuiltInUIsprop. - Implements
BankIdViewNameBuiltInUIto show a polling-status-based spinner and render the QR link above actions. - Extends test mocks and adds unit tests + README docs covering the new opt-in behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/login-web-app/src/haapi-stepper/util/tests/mocks.ts |
Adds BankID polling step and QR link helpers for new tests. |
src/login-web-app/src/haapi-stepper/feature/viewnames/viewname.types.ts |
Introduces enum of viewNames with built-in UIs. |
src/login-web-app/src/haapi-stepper/feature/viewnames/viewname-built-in-uis.ts |
Adds registry + selection logic for built-in UIs. |
src/login-web-app/src/haapi-stepper/feature/viewnames/index.ts |
Barrel exports for the new viewnames feature. |
src/login-web-app/src/haapi-stepper/feature/viewnames/BankIdViewNameBuiltInUI.tsx |
BankID-specific built-in UI rendering. |
src/login-web-app/src/haapi-stepper/feature/steps/HaapiStepperStepUI.tsx |
Integrates built-in UI selection via new enableViewNameBuiltInUIs prop. |
src/login-web-app/src/haapi-stepper/feature/steps/HaapiStepperStepUI.spec.tsx |
Adds tests validating built-in UI opt-in + BankID behavior. |
src/login-web-app/src/haapi-stepper/README.md |
Documents the new built-in UI feature and how to enable it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aleixsuau
force-pushed
the
feature/IS-11241/rename-haapistepper-ui-components
branch
from
429ab4c to
66b0634
Compare
aleixsuau
changed the base branch from
feature/IS-11241/rename-haapistepper-ui-components
to
integration/IS-5161/login-web-app
Rename the six UI components (Actions, Link, Links, Messages, ClientOperation, HaapiSelector) plus HaapiStepperForm and the message element factory to the existing HaapiStepper<Name>UI convention. This disambiguates the React components from the HAAPI data interfaces they render (HaapiStepperLink vs HaapiStepperLinkUI, etc.), preventing import collisions and making it obvious at a glance which layer is being referenced. Also fixes stale HaapiUIStep and Form.tsx references in README and JSDoc. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
aleixsuau
force-pushed
the
feature/IS-11275/viewname-default-render-interceptors
branch
from
872d350 to
e2ec03d
Compare
urre
approved these changes
May 7, 2026
| * | ||
| * The HaapiStepperStepUI component also provides built-in UIs for specific HAAPI `viewName`s that require a more | ||
| * tailored UI than the generic step shell can provide (e.g. the BankID QR code step, which requires lifting | ||
| * the QR code up and showing a spinner while polling). |
Contributor
There was a problem hiding this comment.
Again, I don't think this is needed as it makes it look like the default is flawed.
| * - `false` or `undefined` to keep all built-ins disabled (every view renders through the | ||
| * generic shell). | ||
| * | ||
| * Composition: the matching viewName built-in UI is rendered after the `stepRenderInterceptor` has processed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://curity.atlassian.net/browse/IS-11275
Summary
Adds the built-in
viewNameUIs feature. The first use case covered is the BankID view name (authenticator/bankid/wait/index) to display:pending(independent ofloading).Read added docs (
ui-kit/src/login-web-app/src/haapi-stepper/README.md:117, andui-kit/src/login-web-app/src/haapi-stepper/feature/steps/HaapiStepperStepUI.tsx:84) and tests (ui-kit/src/login-web-app/src/haapi-stepper/feature/steps/HaapiStepperStepUI.tsx:84) for more details.Test plan
Notes