-
Notifications
You must be signed in to change notification settings - Fork 0
Avoid adding project or solution files nested inside a project #51
Copy link
Copy link
Open
Labels
area/reference-generalIssues concerning any reference template in generalIssues concerning any reference template in generalaspect/build-infrastructureIssues concerning aspects of infrastructure for building code in reference templatesIssues concerning aspects of infrastructure for building code in reference templatesconcept/flexibilityIssues concerning flexibility and configurability of the reference templatesIssues concerning flexibility and configurability of the reference templates
Description
Metadata
Metadata
Assignees
Labels
area/reference-generalIssues concerning any reference template in generalIssues concerning any reference template in generalaspect/build-infrastructureIssues concerning aspects of infrastructure for building code in reference templatesIssues concerning aspects of infrastructure for building code in reference templatesconcept/flexibilityIssues concerning flexibility and configurability of the reference templatesIssues concerning flexibility and configurability of the reference templates
While authoring template packages, it is common to find both project (
*.csproj) and solution (*.sln) files nested inside the template project. These are not proper projects, but rather template content files which will be processed as part of runningdotnet new.Currently, running prefect on such template projects will include these template project files in the solution as part of the general scan for
*.csprojfiles, which is incorrect.prefect/src/Prefect/#Rules/SolutionStructureRule.cs
Line 122 in 1cc8f65
Probably the most reliable heuristic will be to exclude any
.csprojfiles nested inside a project folder, as I can see no reason we would ever want to include such nested project files, other than assets for template projects, unit tests, or code generation purposes, none of which require the.csprojfile to be in the solution.