From ddd2a23e140d08a0a85a2599ec1504c11a6b6f7c Mon Sep 17 00:00:00 2001 From: Ties de Kock Date: Sun, 31 Oct 2021 16:14:10 +0100 Subject: [PATCH 1/3] Remove branch target restriction for build on PR --- .github/workflows/codeql.yml | 1 - .github/workflows/go.yml | 1 - 2 files changed, 2 deletions(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 7998d99..2d34081 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -4,7 +4,6 @@ on: push: branches: [ master ] pull_request: - branches: [ master ] jobs: build: diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index cee2414..76a082a 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -4,7 +4,6 @@ on: push: branches: [ master ] pull_request: - branches: [ master ] jobs: build: From 61ce3b0397a888187b6c8a677ddce83445435d2d Mon Sep 17 00:00:00 2001 From: Ties de Kock Date: Sun, 31 Oct 2021 16:14:58 +0100 Subject: [PATCH 2/3] Add golangci-lint --- .github/workflows/lint.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 .github/workflows/lint.yml diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml new file mode 100644 index 0000000..6b561d2 --- /dev/null +++ b/.github/workflows/lint.yml @@ -0,0 +1,20 @@ +name: CI + +on: [push, pull_request] + +jobs: + # The "build" workflow + lint: + # The type of runner that the job will run on + runs-on: ubuntu-latest + + # Steps represent a sequence of tasks that will be executed as part of the job + steps: + # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it + - uses: actions/checkout@v2 + + # Install and run golangci-lint as a separate step, it's much faster this + # way because this action has caching. It'll get run again in `make lint` + # below, but it's still much faster in the end than installing + # golangci-lint manually in the `Run lint` step. + - uses: golangci/golangci-lint-action@v2 From e040aa0a84f094ee7676e6655e30b8d19bce22bf Mon Sep 17 00:00:00 2001 From: Ties de Kock Date: Sun, 31 Oct 2021 16:59:59 +0100 Subject: [PATCH 3/3] Only report new lint errors --- .github/workflows/lint.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 6b561d2..da6f967 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -18,3 +18,5 @@ jobs: # below, but it's still much faster in the end than installing # golangci-lint manually in the `Run lint` step. - uses: golangci/golangci-lint-action@v2 + with: + only-new-issues: true